From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC39BC4332F for ; Sat, 31 Dec 2022 03:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230132AbiLaDzf (ORCPT ); Fri, 30 Dec 2022 22:55:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiLaDzd (ORCPT ); Fri, 30 Dec 2022 22:55:33 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D864BC9C; Fri, 30 Dec 2022 19:55:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8D7AB8162C; Sat, 31 Dec 2022 03:55:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CA4CC433EF; Sat, 31 Dec 2022 03:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672458930; bh=Pa1PYVoJoUZNt9IVRLhwAsdHtIKR1d2rvQTtv41uneE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kDaob7R5MJIEm/6MMBRzNcLBeopos02AnaOOY1AWl962V0JH7bjoW5uf6RczVV6JF u3DN1BbnGpyUeZheC2ziW18NyKTDDusOKI5tzMABqIwh6lejwdAFTIXHuYxhE4g+8F iJ/+FBmG7R7X8jx2nRjVAm0DYIS+0a13/6uIX8+ANCMRyKEBh3TFbioAJFYCMlvaNJ vCWovn3uEOOkAIOM+7CRwzK/2o1AcR9jrTcBabcRL70VNMvWqmRuMzR5igRj2jbHBt Eo8iOwnQ8I+aP23yuIJnDqVBrTB2gTFIMvTVl83xh8F6+j0Ov/sJPKK5A/Ma1D3818 E0xHg6pZpV7dA== Date: Fri, 30 Dec 2022 19:55:29 -0800 From: Jakub Kicinski To: Daniil Tatianin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Message-ID: <20221230195529.67a5266a@kernel.org> In-Reply-To: References: <20221226084353.1914921-1-d-tatianin@yandex-team.ru> <20221229182227.5de48def@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 30 Dec 2022 11:44:02 +0300 Daniil Tatianin wrote: > On 12/30/22 5:22 AM, Jakub Kicinski wrote: > > On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote: > >> Otherwise we would dereference a NULL aggregator pointer when calling > >> __set_agg_ports_ready on the line below. > > > > Fixes tag, please? > Looks like this code was introduced with the initial git import. > Would that still be useful? yessir, the point is to let backporters know how far the bug goes. The initial import is our local equivalent of infinity, for all practical purposes.