From: Bjorn Helgaas <helgaas@kernel.org>
To: "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
Cc: "Neftin, Sasha" <sasha.neftin@intel.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
"Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
"Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
"naamax.meir" <naamax.meir@linux.intel.com>,
Leon Romanovsky <leon@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Mushayev, Nikolay" <nikolay.mushayev@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Efrati, Nir" <nir.efrati@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP
Date: Tue, 3 Jan 2023 13:13:23 -0600 [thread overview]
Message-ID: <20230103191323.GA1011840@bhelgaas> (raw)
In-Reply-To: <CO1PR11MB483539867F2BABC92F586F8696F49@CO1PR11MB4835.namprd11.prod.outlook.com>
On Tue, Jan 03, 2023 at 06:58:36AM +0000, Khandelwal, Rajat wrote:
> ...
> The reason I masked inherently is I witnessed a function
> netxen_mask_aer_correctable() inside
> net/ethernet/qlogic/netxen/netxen_nic_main.c, which masks the
> correctable errors in the corresponding PCIe device.
In my opinion, netxen_mask_aer_correctable() should not exist. The
PCI core should own the PCI_ERR_COR_MASK register.
netxen_mask_aer_correctable() was added by dce87b960cf4 ("netxen: mask
correctable error") with the note that it is a "HW workaround." Maybe
it covers up some hardware defect in the device, although it doesn't
include any evidence of this.
But if we do actually need it, I would rather have the driver set a
quirk bit that the PCI core can use to mask correctable errors so the
AER configuration is all in one place.
Bjorn
next parent reply other threads:[~2023-01-03 19:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CO1PR11MB483539867F2BABC92F586F8696F49@CO1PR11MB4835.namprd11.prod.outlook.com>
2023-01-03 19:13 ` Bjorn Helgaas [this message]
2022-12-29 12:26 [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP Rajat Khandelwal
2023-01-01 7:27 ` [Intel-wired-lan] " Neftin, Sasha
2023-01-01 8:32 ` Leon Romanovsky
2023-01-01 10:34 ` [Intel-wired-lan] " Paul Menzel
2023-01-03 9:54 ` Leon Romanovsky
2023-01-03 11:54 ` Bjorn Helgaas
2023-01-03 12:00 ` Leon Romanovsky
2023-01-03 14:21 ` Bjorn Helgaas
2023-01-03 17:16 ` Leon Romanovsky
2023-01-04 6:31 ` Leon Romanovsky
2023-01-01 10:32 ` Paul Menzel
2023-01-02 17:38 ` Khandelwal, Rajat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103191323.GA1011840@bhelgaas \
--to=helgaas@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay.mushayev@intel.com \
--cc=nir.efrati@intel.com \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=rajat.khandelwal@intel.com \
--cc=rajat.khandelwal@linux.intel.com \
--cc=sasha.neftin@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).