From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCHv3 net-next] sched: multicast sched extack messages
Date: Wed, 4 Jan 2023 20:01:13 -0800 [thread overview]
Message-ID: <20230104200113.08112895@kernel.org> (raw)
In-Reply-To: <20230104091608.1154183-1-liuhangbin@gmail.com>
On Wed, 4 Jan 2023 17:16:08 +0800 Hangbin Liu wrote:
> In commit 81c7288b170a ("sched: cls: enable verbose logging") Marcelo
> made cls could log verbose info for offloading failures, which helps
> improving Open vSwitch debuggability when using flower offloading.
>
> It would also be helpful if userspace monitor tools, like "tc monitor",
> could log this kind of message, as it doesn't require vswitchd log level
> adjusment. Let's add a new function to report the extack message so the
> monitor program could receive the failures. e.g.
If you repost this ever again please make sure you include my tag:
Nacked-by: Jakub Kicinski <kuba@kernel.org>
I explained to you at least twice why this is a terrible idea,
and gave you multiple alternatives.
next prev parent reply other threads:[~2023-01-05 4:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:16 [PATCHv3 net-next] sched: multicast sched extack messages Hangbin Liu
2023-01-05 4:01 ` Jakub Kicinski [this message]
2023-01-05 10:12 ` Hangbin Liu
2023-01-09 15:57 ` Jamal Hadi Salim
[not found] ` <CAM0EoMkw8GA=KA_FXV8v4a-RKYCibK64ngp9hRQeT1UzXY4LCg@mail.gmail.com>
2023-01-09 19:43 ` Jakub Kicinski
2023-01-10 10:17 ` Hangbin Liu
2023-01-10 17:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104200113.08112895@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).