From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
Dave Ertman <david.m.ertman@intel.com>,
netdev@vger.kernel.org, shiraz.saleem@intel.com,
mustafa.ismail@intel.com, jgg@nvidia.com, leonro@nvidia.com,
linux-rdma@vger.kernel.org,
Gurucharan G <gurucharanx.g@intel.com>
Subject: Re: [PATCH net v2 1/3] ice: Prevent set_channel from changing queues while RDMA active
Date: Wed, 4 Jan 2023 20:42:24 -0800 [thread overview]
Message-ID: <20230104204224.31e3eca9@kernel.org> (raw)
In-Reply-To: <20230103230738.1102585-2-anthony.l.nguyen@intel.com>
On Tue, 3 Jan 2023 15:07:36 -0800 Tony Nguyen wrote:
> + mutex_lock(&pf->adev_mutex);
> + if (pf->adev && pf->adev->dev.driver) {
> + netdev_err(dev, "Cannot change channels when RDMA is active\n");
> + ret = -EINVAL;
> + goto adev_unlock;
Since you're have to respin anyway - perhaps -EBUSY here?
next prev parent reply other threads:[~2023-01-05 4:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 23:07 [PATCH net v2 0/3][pull request] Intel Wired LAN Driver Updates 2023-01-03 (ice) Tony Nguyen
2023-01-03 23:07 ` [PATCH net v2 1/3] ice: Prevent set_channel from changing queues while RDMA active Tony Nguyen
2023-01-04 7:45 ` Leon Romanovsky
2023-01-05 4:42 ` Jakub Kicinski [this message]
2023-01-03 23:07 ` [PATCH net v2 2/3] ice: Fix deadlock on the rtnl_mutex Tony Nguyen
2023-01-04 7:44 ` Leon Romanovsky
2023-01-03 23:07 ` [PATCH net v2 3/3] ice: Fix broken link in ice NAPI doc Tony Nguyen
2023-01-04 2:02 ` Bagas Sanjaya
2023-01-05 4:43 ` Jakub Kicinski
2023-01-09 8:54 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104204224.31e3eca9@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).