From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A649FC5479D for ; Thu, 5 Jan 2023 18:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234333AbjAESey (ORCPT ); Thu, 5 Jan 2023 13:34:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235353AbjAESed (ORCPT ); Thu, 5 Jan 2023 13:34:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD345E66B for ; Thu, 5 Jan 2023 10:34:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4BBE761BEC for ; Thu, 5 Jan 2023 18:34:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53164C433D2; Thu, 5 Jan 2023 18:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672943669; bh=BIq2CTRaJJ1CxonxvJsny9Cx9K+hFQhw49+T2thwCyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hKPevcNCcC5t6eSoraD2cNy2DHpwUnJ2bVeI07g9b8rkkdSD5Jxr1NFjPGLwSD418 8UCuLCiEROVcdCVmkQi6zFJSxO5P+f2JztaUYTvd7KmYrLixrFMPRriWx1/JDQJGhJ 4Dql57iOFIqPvLokUNMbyQoKpJT6gmNpfqgQxz6IOHuoHzUS+Ntfc6zuFySKBmKfC2 GUSCkREL03M0CFx5+CTCQBMoMtUKY3scthBjxk2PMT4O5vY2XcD892iqESJUrNeUwp ejeG2Or8oVCMQkQCGvwN783EYNAw2lqTcVaiCmBO+k64Faj3BiJP/9SRkDXLlXGvYH V9Q4sgOuVlSUA== Date: Thu, 5 Jan 2023 10:34:28 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, jacob.e.keller@intel.com Subject: Re: [PATCH net-next v2 03/15] devlink: split out core code Message-ID: <20230105103428.65a4e916@kernel.org> In-Reply-To: References: <20230105040531.353563-1-kuba@kernel.org> <20230105040531.353563-4-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 5 Jan 2023 10:16:40 +0100 Jiri Pirko wrote: > Btw, I don't think it is correct to carry Jacob's review tag around when > the patches changed (not only this one). There's no clear rule for that :( I see more people screaming at submitters for dropping tags than for keeping them so I err on that side myself. Here I think the case is relatively clear, since I'm only doing renames and bike-shedding stuff, and Jake is not one to bike-shed in my experience.