From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next 2/2] net: kfree_skb_list use kmem_cache_free_bulk
Date: Fri, 6 Jan 2023 14:33:10 -0800 [thread overview]
Message-ID: <20230106143310.699197bd@kernel.org> (raw)
In-Reply-To: <167293336786.249536.14237439594457105125.stgit@firesoul>
Hi!
Would it not be better to try to actually defer them (queue to
the deferred free list and try to ship back to the NAPI cache of
the allocating core)? Is the spin lock on the defer list problematic
for fowarding cases (which I'm assuming your target)?
Also the lack of perf numbers is a bit of a red flag.
On Thu, 05 Jan 2023 16:42:47 +0100 Jesper Dangaard Brouer wrote:
> +static void kfree_skb_defer_local(struct sk_buff *skb,
> + struct skb_free_array *sa,
> + enum skb_drop_reason reason)
If we wanna keep the implementation as is - I think we should rename
the thing to say "bulk" rather than "defer" to avoid confusion with
the TCP's "defer to allocating core" scheme..
kfree_skb_list_bulk() ?
next prev parent reply other threads:[~2023-01-06 22:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 15:42 [PATCH net-next 0/2] net: use kmem_cache_free_bulk in kfree_skb_list Jesper Dangaard Brouer
2023-01-05 15:42 ` [PATCH net-next 1/2] net: fix call location in kfree_skb_list_reason Jesper Dangaard Brouer
2023-01-06 19:54 ` Saeed Mahameed
2023-01-06 19:57 ` Saeed Mahameed
2023-01-05 15:42 ` [PATCH net-next 2/2] net: kfree_skb_list use kmem_cache_free_bulk Jesper Dangaard Brouer
2023-01-06 20:09 ` Saeed Mahameed
2023-01-06 22:33 ` Jakub Kicinski [this message]
2023-01-09 12:24 ` Jesper Dangaard Brouer
2023-01-09 19:34 ` Jakub Kicinski
2023-01-09 22:10 ` Alexander H Duyck
2023-01-10 14:52 ` Jesper Dangaard Brouer
2023-01-10 20:20 ` Jakub Kicinski
2023-01-13 13:42 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106143310.699197bd@kernel.org \
--to=kuba@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).