From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1072DC54EBD for ; Fri, 6 Jan 2023 22:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjAFW4A (ORCPT ); Fri, 6 Jan 2023 17:56:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjAFWz7 (ORCPT ); Fri, 6 Jan 2023 17:55:59 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBEC320F for ; Fri, 6 Jan 2023 14:55:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8A5E7B81DD6 for ; Fri, 6 Jan 2023 22:55:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C244AC433F1; Fri, 6 Jan 2023 22:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673045755; bh=Co+hdlFzg6kMwfEil7GilArE6EOHx3LtdALLvnxOQes=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H0PuSzVSfd4avzxghHUVARCgA7AIDC2xcdxIHD75rosRo+7P4zWiZlyhJ1+Bya/uk NQ/UTJgCDZXj2oVyl3tsOZKPR3ijmoPe8MtnBRFmoWTFBv+OJ3F+aomEo01DesY1pv k7wQKDN/Id5qeea1IcL3qPloL73BnC+i43r3BjWnjxjBRKN6JHRoK2hpciFpOT7cn2 SW6txFIrXs0RxhxDDLSic18meDe+U91GCjqCKxP+GAfFoWVvxAYxpe94HQQ1Ismx7P SaMO2RzcjfbN5SWh4WnuSjWyrSLb9ZJ/cDsZ6L/DGBEczNbOlj0yZlI2L3Ang+RA5l WfXq4gpwhuhIA== Date: Fri, 6 Jan 2023 14:55:53 -0800 From: Jakub Kicinski To: Kyle Zeng Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: net: ipv6: raw: fixes null pointer deference in rawv6_push_pending_frames Message-ID: <20230106145553.6dd014f1@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 6 Jan 2023 14:19:52 -0700 Kyle Zeng wrote: > It is posible that the skb_queue_walkloop does not assign csum_skb to a real skb. Not immediately obvious to me how that could happen given prior checks in this function.