From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
Gerhard Engleder <gerhard@engleder-embedded.com>,
netdev@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com,
Gerhard Engleder <gerhard@engleder-embedded.com>
Subject: Re: [PATCH net-next v3 9/9] tsnep: Add XDP RX support
Date: Sat, 7 Jan 2023 11:46:32 +0300 [thread overview]
Message-ID: <202301071414.ritICMHu-lkp@intel.com> (raw)
In-Reply-To: <20230104194132.24637-10-gerhard@engleder-embedded.com>
Hi Gerhard,
url: https://github.com/intel-lab-lkp/linux/commits/Gerhard-Engleder/tsnep-Use-spin_lock_bh-for-TX/20230105-034351
patch link: https://lore.kernel.org/r/20230104194132.24637-10-gerhard%40engleder-embedded.com
patch subject: [PATCH net-next v3 9/9] tsnep: Add XDP RX support
config: arc-randconfig-m041-20230106
compiler: arc-elf-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
New smatch warnings:
drivers/net/ethernet/engleder/tsnep_main.c:641 tsnep_xdp_xmit_back() warn: signedness bug returning '(-14)'
vim +641 drivers/net/ethernet/engleder/tsnep_main.c
dd23b834a352b5 Gerhard Engleder 2023-01-04 631 static bool tsnep_xdp_xmit_back(struct tsnep_adapter *adapter,
^^^^
dd23b834a352b5 Gerhard Engleder 2023-01-04 632 struct xdp_buff *xdp)
dd23b834a352b5 Gerhard Engleder 2023-01-04 633 {
dd23b834a352b5 Gerhard Engleder 2023-01-04 634 struct xdp_frame *xdpf = xdp_convert_buff_to_frame(xdp);
dd23b834a352b5 Gerhard Engleder 2023-01-04 635 int cpu = smp_processor_id();
dd23b834a352b5 Gerhard Engleder 2023-01-04 636 struct netdev_queue *nq;
dd23b834a352b5 Gerhard Engleder 2023-01-04 637 int queue;
dd23b834a352b5 Gerhard Engleder 2023-01-04 638 bool xmit;
dd23b834a352b5 Gerhard Engleder 2023-01-04 639
dd23b834a352b5 Gerhard Engleder 2023-01-04 640 if (unlikely(!xdpf))
dd23b834a352b5 Gerhard Engleder 2023-01-04 @641 return -EFAULT;
return false?
dd23b834a352b5 Gerhard Engleder 2023-01-04 642
dd23b834a352b5 Gerhard Engleder 2023-01-04 643 queue = cpu % adapter->num_tx_queues;
dd23b834a352b5 Gerhard Engleder 2023-01-04 644 nq = netdev_get_tx_queue(adapter->netdev, queue);
dd23b834a352b5 Gerhard Engleder 2023-01-04 645
dd23b834a352b5 Gerhard Engleder 2023-01-04 646 __netif_tx_lock(nq, cpu);
dd23b834a352b5 Gerhard Engleder 2023-01-04 647
dd23b834a352b5 Gerhard Engleder 2023-01-04 648 /* Avoid transmit queue timeout since we share it with the slow path */
dd23b834a352b5 Gerhard Engleder 2023-01-04 649 txq_trans_cond_update(nq);
dd23b834a352b5 Gerhard Engleder 2023-01-04 650
dd23b834a352b5 Gerhard Engleder 2023-01-04 651 xmit = tsnep_xdp_xmit_frame_ring(xdpf, &adapter->tx[queue],
dd23b834a352b5 Gerhard Engleder 2023-01-04 652 TSNEP_TX_TYPE_XDP_TX);
dd23b834a352b5 Gerhard Engleder 2023-01-04 653
dd23b834a352b5 Gerhard Engleder 2023-01-04 654 __netif_tx_unlock(nq);
dd23b834a352b5 Gerhard Engleder 2023-01-04 655
dd23b834a352b5 Gerhard Engleder 2023-01-04 656 return xmit;
dd23b834a352b5 Gerhard Engleder 2023-01-04 657 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-01-07 8:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 19:41 [PATCH net-next v3 0/9] tsnep: XDP support Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 1/9] tsnep: Use spin_lock_bh for TX Gerhard Engleder
2023-01-05 12:40 ` Alexander Lobakin
2023-01-05 19:48 ` Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 2/9] tsnep: Do not print DMA mapping error Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 3/9] tsnep: Add adapter down state Gerhard Engleder
2023-01-05 12:44 ` Alexander Lobakin
2023-01-05 19:54 ` Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 4/9] tsnep: Add XDP TX support Gerhard Engleder
2023-01-05 13:01 ` Alexander Lobakin
2023-01-05 21:13 ` Gerhard Engleder
2023-01-06 22:13 ` Jakub Kicinski
2023-01-06 23:34 ` Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 5/9] tsnep: Substract TSNEP_RX_INLINE_METADATA_SIZE once Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 6/9] tsnep: Support XDP BPF program setup Gerhard Engleder
2023-01-05 17:24 ` Alexander Lobakin
2023-01-05 22:09 ` Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 7/9] tsnep: Prepare RX buffer for XDP support Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 8/9] tsnep: Add RX queue info " Gerhard Engleder
2023-01-05 17:35 ` Alexander Lobakin
2023-01-05 22:28 ` Gerhard Engleder
2023-01-04 19:41 ` [PATCH net-next v3 9/9] tsnep: Add XDP RX support Gerhard Engleder
2023-01-05 17:52 ` Alexander Lobakin
2023-01-05 23:22 ` Gerhard Engleder
2023-01-07 8:46 ` Dan Carpenter [this message]
2023-01-07 20:12 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301071414.ritICMHu-lkp@intel.com \
--to=error27@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).