From: Tom Rix <trix@redhat.com>
To: shayagr@amazon.com, akiyano@amazon.com, darinzon@amazon.com,
ndagan@amazon.com, saeedb@amazon.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
nathan@kernel.org, ndesaulniers@google.com, khalasa@piap.pl,
wsa+renesas@sang-engineering.com, yuancan@huawei.com,
tglx@linutronix.de, 42.hyeyoo@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Tom Rix <trix@redhat.com>
Subject: [PATCH] net: ena: initialize dim_sample
Date: Sun, 8 Jan 2023 09:38:43 -0500 [thread overview]
Message-ID: <20230108143843.2987732-1-trix@redhat.com> (raw)
clang static analysis reports this problem
drivers/net/ethernet/amazon/ena/ena_netdev.c:1821:2: warning: Passed-by-value struct
argument contains uninitialized data (e.g., field: 'comp_ctr') [core.CallAndMessage]
net_dim(&ena_napi->dim, dim_sample);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net_dim can call dim_calc_stats() which uses the comp_ctr element,
so it must be initialized.
Fixes: 282faf61a053 ("net: ena: switch to dim algorithm for rx adaptive interrupt moderation")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index e8ad5ea31aff..938184465eae 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -1805,7 +1805,7 @@ static void ena_dim_work(struct work_struct *w)
static void ena_adjust_adaptive_rx_intr_moderation(struct ena_napi *ena_napi)
{
- struct dim_sample dim_sample;
+ struct dim_sample dim_sample = {};
struct ena_ring *rx_ring = ena_napi->rx_ring;
if (!rx_ring->per_napi_packets)
--
2.27.0
next reply other threads:[~2023-01-08 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 14:38 Tom Rix [this message]
2023-01-09 10:34 ` [PATCH] net: ena: initialize dim_sample Eric Dumazet
2023-01-10 16:58 ` Shay Agroskin
2023-01-10 17:17 ` Tom Rix
2023-01-11 8:46 ` Shay Agroskin
2023-01-11 14:29 ` Tom Rix
2023-01-10 16:44 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230108143843.2987732-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=42.hyeyoo@gmail.com \
--cc=akiyano@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=khalasa@piap.pl \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndagan@amazon.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=tglx@linutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox