From: Jakub Kicinski <kuba@kernel.org>
To: "Mogilappagari, Sudheer" <sudheer.mogilappagari@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mkubecek@suse.cz" <mkubecek@suse.cz>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler for get rss (-x)
Date: Mon, 9 Jan 2023 11:13:40 -0800 [thread overview]
Message-ID: <20230109111340.73567a60@kernel.org> (raw)
In-Reply-To: <IA1PR11MB62667E12E921F5D2D56637DBE4FE9@IA1PR11MB6266.namprd11.prod.outlook.com>
On Mon, 9 Jan 2023 18:07:45 +0000 Mogilappagari, Sudheer wrote:
> > > Are you suggesting we need to use ioctl for fetching ring info to
> > > avoid mix-up. Is there alternative way to do it ?
> >
> > No no, look how the strings for hfunc names are fetched - they are
> > fetched over a different socket, right?
>
> global_stringset is using nlctx->ethnl2_socket. Are you suggesting use
> of it for fetching channels info too ?
>
> ret = netlink_init_ethnl2_socket(nlctx);
> ...
> hash_funcs = global_stringset(ETH_SS_RSS_HASH_FUNCS, nlctx->ethnl2_socket);
Yessir.
next prev parent reply other threads:[~2023-01-09 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 1:12 [PATCH ethtool-next v4 0/2] add netlink support for rss get Sudheer Mogilappagari
2022-12-29 1:12 ` [PATCH ethtool-next v4 1/2] Move code that print rss info into common file Sudheer Mogilappagari
2022-12-29 1:12 ` [PATCH ethtool-next v4 2/2] netlink: add netlink handler for get rss (-x) Sudheer Mogilappagari
2023-01-03 0:33 ` Jakub Kicinski
2023-01-06 17:41 ` Mogilappagari, Sudheer
2023-01-06 21:41 ` Jakub Kicinski
2023-01-09 18:07 ` Mogilappagari, Sudheer
2023-01-09 19:13 ` Jakub Kicinski [this message]
2023-01-09 20:10 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109111340.73567a60@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).