From: Jakub Kicinski <kuba@kernel.org>
To: <yang.yang29@zte.com.cn>
Cc: <santosh.shilimkar@oracle.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<rds-devel@oss.oracle.com>, <linux-kernel@vger.kernel.org>,
<xu.panda@zte.com.cn>
Subject: Re: [PATCH net-next] net/rds: use strscpy() to instead of strncpy()
Date: Mon, 9 Jan 2023 19:48:34 -0800 [thread overview]
Message-ID: <20230109194834.24e06def@kernel.org> (raw)
In-Reply-To: <202301091948433010050@zte.com.cn>
On Mon, 9 Jan 2023 19:48:43 +0800 (CST) yang.yang29@zte.com.cn wrote:
> BUG_ON(strlen(names[i]) >= sizeof(ctr.name));
> - strncpy(ctr.name, names[i], sizeof(ctr.name) - 1);
> - ctr.name[sizeof(ctr.name) - 1] = '\0';
> + strscpy(ctr.name, names[i], sizeof(ctr.name));
You can make use of the fact that strscpy returns useful information
and the copy and the preceding BUG_ON() together.
prev parent reply other threads:[~2023-01-10 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 11:48 [PATCH net-next] net/rds: use strscpy() to instead of strncpy() yang.yang29
2023-01-10 3:48 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109194834.24e06def@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).