netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Rahul Rameshbabu <rrameshbabu@nvidia.com>,
	Gal Pressman <gal@nvidia.com>
Subject: [net 12/16] net/mlx5: Fix ptp max frequency adjustment range
Date: Mon,  9 Jan 2023 22:11:19 -0800	[thread overview]
Message-ID: <20230110061123.338427-13-saeed@kernel.org> (raw)
In-Reply-To: <20230110061123.338427-1-saeed@kernel.org>

From: Rahul Rameshbabu <rrameshbabu@nvidia.com>

.max_adj of ptp_clock_info acts as an absolute value for the amount in ppb
that can be set for a single call of .adjfine. This means that a single
call to .getfine cannot be greater than .max_adj or less than -(.max_adj).
Provides correct value for max frequency adjustment value supported by
devices.

Fixes: 3d8c38af1493 ("net/mlx5e: Add PTP Hardware Clock (PHC) support")
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
index 69cfe60c558a..69318b143268 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
@@ -681,7 +681,7 @@ static int mlx5_ptp_verify(struct ptp_clock_info *ptp, unsigned int pin,
 static const struct ptp_clock_info mlx5_ptp_clock_info = {
 	.owner		= THIS_MODULE,
 	.name		= "mlx5_ptp",
-	.max_adj	= 100000000,
+	.max_adj	= 50000000,
 	.n_alarm	= 0,
 	.n_ext_ts	= 0,
 	.n_per_out	= 0,
-- 
2.39.0


  parent reply	other threads:[~2023-01-10  6:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10  6:11 [pull request][net 00/16] mlx5 fixes 2023-01-09 Saeed Mahameed
2023-01-10  6:11 ` [net 01/16] net/mlx5: DR, Fix 'stack frame size exceeds limit' error in dr_rule Saeed Mahameed
2023-01-11 13:00   ` patchwork-bot+netdevbpf
2023-01-10  6:11 ` [net 02/16] net/mlx5: check attr pointer validity before dereferencing it Saeed Mahameed
2023-01-10  6:11 ` [net 03/16] net/mlx5e: TC, Keep mod hdr actions after mod hdr alloc Saeed Mahameed
2023-01-10  6:11 ` [net 04/16] net/mlx5: Fix command stats access after free Saeed Mahameed
2023-01-10  6:11 ` [net 05/16] net/mlx5e: Verify dev is present for fix features ndo Saeed Mahameed
2023-01-10  6:11 ` [net 06/16] net/mlx5e: IPoIB, Block queue count configuration when sub interfaces are present Saeed Mahameed
2023-01-10  6:11 ` [net 07/16] net/mlx5e: IPoIB, Block PKEY interfaces with less rx queues than parent Saeed Mahameed
2023-01-10  6:11 ` [net 08/16] net/mlx5e: IPoIB, Fix child PKEY interface stats on rx path Saeed Mahameed
2023-01-10  6:11 ` [net 09/16] net/mlx5e: TC, ignore match level for post meter rules Saeed Mahameed
2023-01-10  6:11 ` [net 10/16] net/mlx5e: TC, Restore pkt rate policing support Saeed Mahameed
2023-01-10  6:11 ` [net 11/16] net/mlx5e: Fix memory leak on updating vport counters Saeed Mahameed
2023-01-10  6:11 ` Saeed Mahameed [this message]
2023-01-10  6:11 ` [net 13/16] net/mlx5e: Don't support encap rules with gbp option Saeed Mahameed
2023-01-10  6:11 ` [net 14/16] net/mlx5: E-switch, Coverity: overlapping copy Saeed Mahameed
2023-01-10  6:11 ` [net 15/16] net/mlx5e: Fix macsec ssci attribute handling in offload path Saeed Mahameed
2023-01-10  6:11 ` [net 16/16] net/mlx5e: Fix macsec possible null dereference when updating MAC security entity (SecY) Saeed Mahameed
2023-01-11  2:01 ` [pull request][net 00/16] mlx5 fixes 2023-01-09 Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110061123.338427-13-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rrameshbabu@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).