From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EF9C46467 for ; Tue, 10 Jan 2023 06:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbjAJGLo (ORCPT ); Tue, 10 Jan 2023 01:11:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjAJGLk (ORCPT ); Tue, 10 Jan 2023 01:11:40 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F161F1DF17 for ; Mon, 9 Jan 2023 22:11:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 886A4614E5 for ; Tue, 10 Jan 2023 06:11:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF3CCC433EF; Tue, 10 Jan 2023 06:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673331098; bh=p2xe9j5bUtXdeCmlHn9gLmikw+HeKF5lGOmzBl/uE8k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UDeMil1NezNkGN6zcknYeXOhz8Xim/h4D5oiAiadgjGEOl6RPIvZXthHVAPqJQTdJ lFNBAD8GpATUpLv6hgUm/l2Z8rf6wE04fyJ59oKqEKeETdHgy5E86tyFnk3M/AlkP+ 4+FGFeu3LGD7uKgY4hAGeQgiV1P/JF7J1d8OXR8/+CI3j8ZFaLX4ROENtxGwMypOuU kcwy0pQYKsitP8WpVBrM43grJl2Cl+IfD5JPVqjHmT+ds0W+zJgcAc2G/vOgfaotnd I5R8pHzkg2BSLtaU9jAwYu0XoCqat33J9ZdBA1O/jUEvHlaz4X3nG6Kdy7o+XF++UR hIQacwSxwKJlQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Ariel Levkovich , kernel test robot , Dan Carpenter Subject: [net 02/16] net/mlx5: check attr pointer validity before dereferencing it Date: Mon, 9 Jan 2023 22:11:09 -0800 Message-Id: <20230110061123.338427-3-saeed@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110061123.338427-1-saeed@kernel.org> References: <20230110061123.338427-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ariel Levkovich Fix attr pointer validity checks after it was already dereferenced. Fixes: cb0d54cbf948 ("net/mlx5e: Fix wrong source vport matching on tunnel rule") Signed-off-by: Ariel Levkovich Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index e455b215c708..75b77dd2392b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -143,7 +143,7 @@ mlx5_eswitch_set_rule_source_port(struct mlx5_eswitch *esw, if (mlx5_esw_indir_table_decap_vport(attr)) vport = mlx5_esw_indir_table_decap_vport(attr); - if (attr && !attr->chain && esw_attr->int_port) + if (!attr->chain && esw_attr && esw_attr->int_port) metadata = mlx5e_tc_int_port_get_metadata_for_match(esw_attr->int_port); else -- 2.39.0