From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7E868C54EBC
	for <netdev@archiver.kernel.org>; Tue, 10 Jan 2023 20:21:11 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232181AbjAJUVK (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 10 Jan 2023 15:21:10 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35836 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231645AbjAJUVH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 10 Jan 2023 15:21:07 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC4DD2626
        for <netdev@vger.kernel.org>; Tue, 10 Jan 2023 12:21:02 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 4BFE1B81993
        for <netdev@vger.kernel.org>; Tue, 10 Jan 2023 20:21:01 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85A4BC433D2;
        Tue, 10 Jan 2023 20:20:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1673382059;
        bh=We64TQQCFYC7BHq19FykKjTXfsPMIq8eE8w+xtKyiXA=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=trCNz8d4RR/BJ1tCMNMh706xMBalrbHtw7bx1a6BYfAWsZFvl39ziNbdKGpur39Tx
         /MCwez1FkAOXzIg1V5LikfvKLh5xHXqK26IwrtPf0Gx4FCkP50umZEIqSPQhQzPEol
         Es9N/NTH+KnIb2Btdjn2Tqv5+DdQvpLaeG4jS2VNmUlCmcjMiYkC5h1Yfq1bBOCWRP
         MzhdxEmYS2I9mWwfAbmPm+cOeaqkFwEsJJwuzqbJ88BGJEl9S68ocCtfriOtdr/OPl
         5v2163YCrzYE+d9Hyl+ThxPmsOx6bTF7poJ+m+jFNc6SqjLQhZvQugTwzVr4O4/EQ/
         zvtvx8UHsai3Q==
Date:   Tue, 10 Jan 2023 12:20:58 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc:     Alexander H Duyck <alexander.duyck@gmail.com>, brouer@redhat.com,
        netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next 2/2] net: kfree_skb_list use
 kmem_cache_free_bulk
Message-ID: <20230110122058.60672695@kernel.org>
In-Reply-To: <adf92243-689e-6013-293f-5464af317594@redhat.com>
References: <167293333469.249536.14941306539034136264.stgit@firesoul>
        <167293336786.249536.14237439594457105125.stgit@firesoul>
        <20230106143310.699197bd@kernel.org>
        <fa1c57de-52f6-719f-7298-c606c119d1ab@redhat.com>
        <20230109113409.2d5fab44@kernel.org>
        <fa307736d5448733f08a5a700bc9c647b383a553.camel@gmail.com>
        <adf92243-689e-6013-293f-5464af317594@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, 10 Jan 2023 15:52:48 +0100 Jesper Dangaard Brouer wrote:
> > Rather than defer_local would it maybe make more sense to look at
> > naming it something like "kfree_skb_add_bulk"? Basically we are
> > building onto the list of buffers to free so I figure something like an
> > "add" or "append" would make sense.
> 
> I agree with Alex

Alex's suggestion (kfree_skb_add_bulk) sgtm.