From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CFFAC54EBC for ; Wed, 11 Jan 2023 02:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233498AbjAKC0O (ORCPT ); Tue, 10 Jan 2023 21:26:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234716AbjAKC0M (ORCPT ); Tue, 10 Jan 2023 21:26:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E19F1168 for ; Tue, 10 Jan 2023 18:26:11 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1A1B5B81A9C for ; Wed, 11 Jan 2023 02:26:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C9B7C433EF; Wed, 11 Jan 2023 02:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673403968; bh=d5Nwk+cB3rbmhsM5YkZwZ3Z1FTo/sexZC/I5snZnaVc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BXkU72AHBTBpZ/+s/BlNuXTEulukVbMCY05hU0PMyZbZab5RGDjwnc/7rzb4R1Tqr K0RZlxtHY+lHu/Hq2fd/vHuF6pZdccEQ1swTv5Tv/lnxYBGT3JZWLo8NEPwsEmkgoT KKeKFi8dz/SNRq/QJ1BhwzhevPPpsNj9q4GBEB3BRomLKsRB9JdHa2Avp1rR1LFlSQ cAz7AZa/px5Orhsgc11mx22qZLf9FbvNR3Cp5D32sP9fxOuXgO4mwUSQHdvCbZ9vSX kCJyIuTudms/cJWJfYBCiIccnZf/yHumVlz6ms3Mk3dj4u6IilOiwwGMgGAUDPhzL+ lnIx6MikP/nEA== Date: Tue, 10 Jan 2023 18:26:07 -0800 From: Jakub Kicinski To: Tony Nguyen Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, Jiasheng Jiang , netdev@vger.kernel.org, Jiri Pirko , Gurucharan G Subject: Re: [PATCH net 2/2] ice: Add check for kzalloc Message-ID: <20230110182607.3a41ab85@kernel.org> In-Reply-To: <20230109225358.3478060-3-anthony.l.nguyen@intel.com> References: <20230109225358.3478060-1-anthony.l.nguyen@intel.com> <20230109225358.3478060-3-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 9 Jan 2023 14:53:58 -0800 Tony Nguyen wrote: > @@ -470,21 +473,23 @@ static struct tty_driver *ice_gnss_create_tty_driver(struct ice_pf *pf) > err = tty_register_driver(tty_driver); > if (err) { > dev_err(dev, "Failed to register TTY driver err=%d\n", err); > - > - for (i = 0; i < ICE_GNSS_TTY_MINOR_DEVICES; i++) { > - tty_port_destroy(pf->gnss_tty_port[i]); > - kfree(pf->gnss_tty_port[i]); > - } > - kfree(ttydrv_name); > - tty_driver_kref_put(pf->ice_gnss_tty_driver); > - > - return NULL; > + goto err_out; FTR I think that depending on i == ICE_GNSS_TTY_MINOR_DEVICES here is fragile. I can merge as is, since the code is technically correct, but what you should have done is crate a new label, say err_unreg_all_ports, do: goto err_unreg_all_ports; > } > > for (i = 0; i < ICE_GNSS_TTY_MINOR_DEVICES; i++) > dev_info(dev, "%s%d registered\n", ttydrv_name, i); > > return tty_driver; > + And here add: err_unreg_all_ports: i = ICE_GNSS_TTY_MINOR_DEVICES; > +err_out: > + while (i--) { > + tty_port_destroy(pf->gnss_tty_port[i]); > + kfree(pf->gnss_tty_port[i]); > + } > + kfree(ttydrv_name); > + tty_driver_kref_put(pf->ice_gnss_tty_driver); > + > + return NULL;