From: Magnus Karlsson <magnus.karlsson@gmail.com>
To: magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org,
daniel@iogearbox.net, netdev@vger.kernel.org,
maciej.fijalkowski@intel.com, bpf@vger.kernel.org, yhs@fb.com,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, tirthendu.sarkar@intel.com
Cc: jonathan.lemon@gmail.com
Subject: [PATCH bpf-next v3 01/15] selftests/xsk: print correct payload for packet dump
Date: Wed, 11 Jan 2023 10:35:12 +0100 [thread overview]
Message-ID: <20230111093526.11682-2-magnus.karlsson@gmail.com> (raw)
In-Reply-To: <20230111093526.11682-1-magnus.karlsson@gmail.com>
From: Magnus Karlsson <magnus.karlsson@intel.com>
Print the correct payload when the packet dump option is selected. The
network to host conversion was forgotten and the payload was
erronously declared to be an int instead of an unsigned int.
Fixes: facb7cb2e909 ("selftests/bpf: Xsk selftests - SKB POLL, NOPOLL")
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
tools/testing/selftests/bpf/xskxceiver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
index 162d3a516f2c..2ff43b22180f 100644
--- a/tools/testing/selftests/bpf/xskxceiver.c
+++ b/tools/testing/selftests/bpf/xskxceiver.c
@@ -767,7 +767,7 @@ static void pkt_dump(void *pkt, u32 len)
struct ethhdr *ethhdr;
struct udphdr *udphdr;
struct iphdr *iphdr;
- int payload, i;
+ u32 payload, i;
ethhdr = pkt;
iphdr = pkt + sizeof(*ethhdr);
@@ -792,7 +792,7 @@ static void pkt_dump(void *pkt, u32 len)
fprintf(stdout, "DEBUG>> L4: udp_hdr->src: %d\n", ntohs(udphdr->source));
fprintf(stdout, "DEBUG>> L4: udp_hdr->dst: %d\n", ntohs(udphdr->dest));
/*extract L5 frame */
- payload = *((uint32_t *)(pkt + PKT_HDR_SIZE));
+ payload = ntohl(*((u32 *)(pkt + PKT_HDR_SIZE)));
fprintf(stdout, "DEBUG>> L5: payload: %d\n", payload);
fprintf(stdout, "---------------------------------------\n");
--
2.34.1
next prev parent reply other threads:[~2023-01-11 9:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 9:35 [PATCH bpf-next v3 00/15] selftests/xsk: speed-ups, fixes, and new XDP programs Magnus Karlsson
2023-01-11 9:35 ` Magnus Karlsson [this message]
2023-01-11 9:35 ` [PATCH bpf-next v3 02/15] selftests/xsk: do not close unused file descriptors Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 03/15] selftests/xsk: submit correct number of frames in populate_fill_ring Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 04/15] selftests/xsk: print correct error codes when exiting Magnus Karlsson
2023-01-12 2:23 ` Alexei Starovoitov
2023-01-12 9:29 ` Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 05/15] selftests/xsk: remove unused variable outstanding_tx Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 06/15] selftests/xsk: add debug option for creating netdevs Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 07/15] selftests/xsk: replace asm acquire/release implementations Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 08/15] selftests/xsk: remove namespaces Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 09/15] selftests/xsk: load and attach XDP program only once per mode Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 10/15] selftests/xsk: remove unnecessary code in control path Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 11/15] selftests/xsk: get rid of built-in XDP program Magnus Karlsson
2023-01-12 2:16 ` Alexei Starovoitov
2023-01-11 9:35 ` [PATCH bpf-next v3 12/15] selftests/xsk: add test when some packets are XDP_DROPed Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 13/15] selftests/xsk: merge dual and single thread dispatchers Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 14/15] selftests/xsk: automatically restore packet stream Magnus Karlsson
2023-01-11 9:35 ` [PATCH bpf-next v3 15/15] selftests/xsk: automatically switch XDP programs Magnus Karlsson
2023-01-12 2:30 ` [PATCH bpf-next v3 00/15] selftests/xsk: speed-ups, fixes, and new " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111093526.11682-2-magnus.karlsson@gmail.com \
--to=magnus.karlsson@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kpsingh@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tirthendu.sarkar@intel.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox