From: Jakub Kicinski <kuba@kernel.org>
To: "Arinzon, David" <darinzon@amazon.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>
Subject: Re: [PATCH V1 net-next 0/5] Add devlink support to ena
Date: Wed, 11 Jan 2023 12:00:03 -0800 [thread overview]
Message-ID: <20230111120003.1a2e2357@kernel.org> (raw)
In-Reply-To: <29a2fdae8f344ff48aeb223d1c3c78ad@amazon.com>
On Wed, 11 Jan 2023 19:31:39 +0000 Arinzon, David wrote:
> If the packet network headers are not within the size of the LLQ entry, then the packet will
> be dropped. So I'll say that c) describes the impact the best given that certain types of
> traffic will not succeed or have disruptions due to dropped TX packets.
I see. Sounds like it could be a fit for
DEVLINK_ATTR_ESWITCH_INLINE_MODE ? But that one configures the depth of
the headers copied inline, rather than bytes. We could add a value for
"tunneled" and have that imply 256B LLQ in case of ena.
The other option is to introduce the concept of "max length of inline
data" to ethtool, and add a new netlink attribute to ethtool -g.
Either way - the length of "inline|push" data is not a ena-specific
concept, so using private knobs (devlink params or ethtool flags) is
not appropriate upstream. We should add a bona fide uAPI for it.
next prev parent reply other threads:[~2023-01-11 20:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 10:35 [PATCH V1 net-next 0/5] Add devlink support to ena David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 1/5] net: ena: Register ena device to devlink David Arinzon
2023-01-09 5:59 ` Kuniyuki Iwashima
2023-01-10 15:17 ` Arinzon, David
2023-01-08 10:35 ` [PATCH V1 net-next 2/5] net: ena: Add devlink reload functionality David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 3/5] net: ena: Configure large LLQ using devlink params David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 4/5] net: ena: Several changes to support large LLQ configuration David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 5/5] net: ena: Add devlink documentation David Arinzon
2023-01-08 20:15 ` kernel test robot
2023-01-09 6:00 ` Kuniyuki Iwashima
2023-01-10 15:20 ` Arinzon, David
2023-01-10 0:45 ` [PATCH V1 net-next 0/5] Add devlink support to ena Jakub Kicinski
2023-01-10 20:11 ` Arinzon, David
2023-01-10 20:44 ` Jakub Kicinski
2023-01-11 8:58 ` Arinzon, David
2023-01-11 19:00 ` Jakub Kicinski
2023-01-11 19:31 ` Arinzon, David
2023-01-11 20:00 ` Jakub Kicinski [this message]
2023-01-11 21:21 ` Arinzon, David
2023-01-12 3:39 ` Jakub Kicinski
2023-01-12 10:31 ` Gal Pressman
2023-01-12 13:47 ` Shay Agroskin
2023-01-12 19:56 ` Jakub Kicinski
2023-01-15 10:05 ` Gal Pressman
2023-01-17 17:31 ` Jakub Kicinski
2023-01-16 14:23 ` Shay Agroskin
2023-01-17 17:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111120003.1a2e2357@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=alisaidi@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=itzko@amazon.com \
--cc=matua@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=osamaabb@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).