From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
Jiasheng Jiang <jiasheng@iscas.ac.cn>, <netdev@vger.kernel.org>,
Jiri Pirko <jiri@nvidia.com>,
Gurucharan G <gurucharanx.g@intel.com>
Subject: Re: [PATCH net 2/2] ice: Add check for kzalloc
Date: Wed, 11 Jan 2023 12:01:44 -0800 [thread overview]
Message-ID: <20230111120144.48ecac23@kernel.org> (raw)
In-Reply-To: <46ee9dd9-4895-80a2-a846-6444a72a15c2@intel.com>
On Wed, 11 Jan 2023 11:31:55 -0800 Tony Nguyen wrote:
> Hi Jakub,
>
> Thanks for the suggestion/improvement. This won't be here much longer as
> we will be converting to use the kernel infrastructure [1] soon, but
> will keep this in mind for the future.
>
> This was mainly to ensure the existing implementations got
> corrected/could be backported.
Ack, to be clear - I did not mean to request a follow up.
Only to suggest a better way of dealing with the error path
for future code.
next prev parent reply other threads:[~2023-01-11 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:53 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2023-01-09 (ice) Tony Nguyen
2023-01-09 22:53 ` [PATCH net 1/2] ice: Fix potential memory leak in ice_gnss_tty_write() Tony Nguyen
2023-01-09 22:53 ` [PATCH net 2/2] ice: Add check for kzalloc Tony Nguyen
2023-01-10 10:56 ` Leon Romanovsky
2023-01-11 2:26 ` Jakub Kicinski
2023-01-11 19:31 ` Tony Nguyen
2023-01-11 20:01 ` Jakub Kicinski [this message]
2023-01-11 2:30 ` [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2023-01-09 (ice) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111120144.48ecac23@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=jiasheng@iscas.ac.cn \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).