From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1C7C63797 for ; Wed, 11 Jan 2023 20:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239563AbjAKUFl (ORCPT ); Wed, 11 Jan 2023 15:05:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239601AbjAKUFP (ORCPT ); Wed, 11 Jan 2023 15:05:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14BA844C4C for ; Wed, 11 Jan 2023 12:01:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5845A61DEA for ; Wed, 11 Jan 2023 20:01:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 823B9C433F0; Wed, 11 Jan 2023 20:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673467305; bh=k6o4rGki1ykT0BZIZuKNDnKUaozyi9eBYJymVD77iwk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FfeaKkZQDrcW0csRz6DZVEcy7IJLbvGFpSN5mGDvgDZ/uxVsWjYYmY2VVv3KxVHRr X4dGJaWxQmIt7pEXJXA7XhYIvhtnqQzuYlddfkZNOgTnMZr4V0Q9BTUFdBb+SQdD6M SO3EO2CWl+idEeKmVx/RIrVXfzGIeGZL88hqAg97AZp2p6zUjwhA088SgXaWkYYUL8 T17UwH4sAFbspfnpNNsBTGfzfwh9cYMV096RUAOQTTKXUK8hD625Ysa2EmKAyG7DvK 0FoQZFptljRz0vVYdH7MaBZQCSC3Q0ybIeEPIhmUHb3f0qhVF4i6viODEDy6oEouRP Yi+RPzYvtzQ5g== Date: Wed, 11 Jan 2023 12:01:44 -0800 From: Jakub Kicinski To: Tony Nguyen Cc: , , , Jiasheng Jiang , , Jiri Pirko , Gurucharan G Subject: Re: [PATCH net 2/2] ice: Add check for kzalloc Message-ID: <20230111120144.48ecac23@kernel.org> In-Reply-To: <46ee9dd9-4895-80a2-a846-6444a72a15c2@intel.com> References: <20230109225358.3478060-1-anthony.l.nguyen@intel.com> <20230109225358.3478060-3-anthony.l.nguyen@intel.com> <20230110182607.3a41ab85@kernel.org> <46ee9dd9-4895-80a2-a846-6444a72a15c2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 11 Jan 2023 11:31:55 -0800 Tony Nguyen wrote: > Hi Jakub, > > Thanks for the suggestion/improvement. This won't be here much longer as > we will be converting to use the kernel infrastructure [1] soon, but > will keep this in mind for the future. > > This was mainly to ensure the existing implementations got > corrected/could be backported. Ack, to be clear - I did not mean to request a follow up. Only to suggest a better way of dealing with the error path for future code.