From: Jakub Kicinski <kuba@kernel.org>
To: "Palczewski, Mateusz" <mateusz.palczewski@intel.com>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: Re: [PATCH net v2] ice: Fix deadlock on the rtnl_mutex
Date: Thu, 12 Jan 2023 11:14:50 -0800 [thread overview]
Message-ID: <20230112111450.2eefe7b6@kernel.org> (raw)
In-Reply-To: <DM4PR11MB5293E8540016AA8AB2E139F587FD9@DM4PR11MB5293.namprd11.prod.outlook.com>
On Thu, 12 Jan 2023 13:31:06 +0000 Palczewski, Mateusz wrote:
> >Why do cases which jump to err_vectors no need any changes?
>
> During my testing I saw no issues with cases when goto err_vectors
> were used. Did You manage to have other results?
I'm just reviewing the code.
Exhaustively testing all the cases is probably very hard,
which is why we generally try to reason about the code
from first principles.
IOW "it didn't fail in my testing" is rarely a sufficient proof
upstream.
prev parent reply other threads:[~2023-01-12 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 12:05 [PATCH net v2] ice: Fix deadlock on the rtnl_mutex Mateusz Palczewski
2023-01-05 13:18 ` Leon Romanovsky
2023-01-05 18:45 ` Jakub Kicinski
2023-01-12 13:31 ` Palczewski, Mateusz
2023-01-12 19:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112111450.2eefe7b6@kernel.org \
--to=kuba@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=leon@kernel.org \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).