From: Jakub Kicinski <kuba@kernel.org>
To: Shay Agroskin <shayagr@amazon.com>
Cc: Gal Pressman <gal@nvidia.com>,
"Arinzon, David" <darinzon@amazon.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>
Subject: Re: [PATCH V1 net-next 0/5] Add devlink support to ena
Date: Thu, 12 Jan 2023 11:56:13 -0800 [thread overview]
Message-ID: <20230112115613.0a33f6c4@kernel.org> (raw)
In-Reply-To: <pj41zltu0vn9o7.fsf@u570694869fb251.ant.amazon.com>
On Thu, 12 Jan 2023 15:47:13 +0200 Shay Agroskin wrote:
> Gal Pressman <gal@nvidia.com> writes:
> > TX copybreak? When the user sets it to > 96 bytes, use the large
> > LLQ.
> >
> > BTW, shouldn't ethtool's tx_push reflect the fact that LLQs are
> > being
> > used? I don't see it used in ena.
>
> Using tx copybreak does sound like it can work for our use
> case. Thanks for the tip Gal (:
>
> Jakub, do you see an issue with utilizing tx_copybreak ethtool
> parameter instead of the devlink param in this patchset ?
IDK, the semantics don't feel close enough.
As a user I'd set tx_copybreak only on systems which have IOMMU enabled
(or otherwise have high cost of DMA mapping), to save CPU cycles.
The ena feature does not seem to be about CPU cycle saving (likely
the opposite, in fact), and does not operate on full segments AFAIU.
Hence my preference to expose it as a new tx_push_buf_len, combining
the semantics of tx_push and rx_buf_len.
next prev parent reply other threads:[~2023-01-12 19:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 10:35 [PATCH V1 net-next 0/5] Add devlink support to ena David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 1/5] net: ena: Register ena device to devlink David Arinzon
2023-01-09 5:59 ` Kuniyuki Iwashima
2023-01-10 15:17 ` Arinzon, David
2023-01-08 10:35 ` [PATCH V1 net-next 2/5] net: ena: Add devlink reload functionality David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 3/5] net: ena: Configure large LLQ using devlink params David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 4/5] net: ena: Several changes to support large LLQ configuration David Arinzon
2023-01-08 10:35 ` [PATCH V1 net-next 5/5] net: ena: Add devlink documentation David Arinzon
2023-01-08 20:15 ` kernel test robot
2023-01-09 6:00 ` Kuniyuki Iwashima
2023-01-10 15:20 ` Arinzon, David
2023-01-10 0:45 ` [PATCH V1 net-next 0/5] Add devlink support to ena Jakub Kicinski
2023-01-10 20:11 ` Arinzon, David
2023-01-10 20:44 ` Jakub Kicinski
2023-01-11 8:58 ` Arinzon, David
2023-01-11 19:00 ` Jakub Kicinski
2023-01-11 19:31 ` Arinzon, David
2023-01-11 20:00 ` Jakub Kicinski
2023-01-11 21:21 ` Arinzon, David
2023-01-12 3:39 ` Jakub Kicinski
2023-01-12 10:31 ` Gal Pressman
2023-01-12 13:47 ` Shay Agroskin
2023-01-12 19:56 ` Jakub Kicinski [this message]
2023-01-15 10:05 ` Gal Pressman
2023-01-17 17:31 ` Jakub Kicinski
2023-01-16 14:23 ` Shay Agroskin
2023-01-17 17:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112115613.0a33f6c4@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=alisaidi@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=itzko@amazon.com \
--cc=matua@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=osamaabb@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).