From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"Y . b . Lu" <yangbo.lu@nxp.com>
Subject: Re: [PATCH net] net: enetc: avoid deadlock in enetc_tx_onestep_tstamp()
Date: Thu, 12 Jan 2023 23:36:29 +0200 [thread overview]
Message-ID: <20230112213629.4luzdpktiq7ho3pk@skbuf> (raw)
In-Reply-To: <CAKgT0UfnRceCA__HkpVnONO_AAp+wt+1GC2b6-vNk8oPh6aV9g@mail.gmail.com>
On Thu, Jan 12, 2023 at 01:29:21PM -0800, Alexander Duyck wrote:
> One other question I had. How do you handle the event that
> enetc_start_xmit returns NETDEV_TX_BUSY or causes the packet to go
> down the drop_packet_err path?
We don't. If the enetc_start_xmit() asks the qdisc to requeue the skb
via NETDEV_TX_BUSY, we aren't going to do that, because we aren't the
qdisc, or if the packet just gets dropped without being mapped into the
TX ring, ENETC_TX_ONESTEP_TSTAMP_IN_PROGRESS will remain set with no
possibility of ever becoming unset ever again.
next prev parent reply other threads:[~2023-01-12 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 10:54 [PATCH net] net: enetc: avoid deadlock in enetc_tx_onestep_tstamp() Vladimir Oltean
2023-01-12 17:48 ` Alexander H Duyck
2023-01-12 18:53 ` Vladimir Oltean
2023-01-12 21:29 ` Alexander Duyck
2023-01-12 21:36 ` Vladimir Oltean [this message]
2023-01-12 21:54 ` Alexander Duyck
2023-01-14 5:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112213629.4luzdpktiq7ho3pk@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=alexander.duyck@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox