From: Jakub Kicinski <kuba@kernel.org>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: "Alexander Duyck" <alexander.duyck@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Subash Abhinov Kasiviswanathan" <quic_subashab@quicinc.com>,
"Sean Tranchetti" <quic_stranche@quicinc.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Alexander Lobakin" <alexandr.lobakin@intel.com>,
"Gal Pressman" <gal@nvidia.com>,
"Dave Taht" <dave.taht@gmail.com>, "Bjørn Mork" <bjorn@mork.no>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/3] add tx packets aggregation to ethtool and rmnet
Date: Fri, 13 Jan 2023 11:48:00 -0800 [thread overview]
Message-ID: <20230113114800.357a96e2@kernel.org> (raw)
In-Reply-To: <CAKgT0Ueb7AA3NrwxFX7VjS_h1j-kOdXUGYchTjwCh9ah1kpbZA@mail.gmail.com>
On Fri, 13 Jan 2023 08:16:48 -0800 Alexander Duyck wrote:
> > ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES works also as a way to determine
> > that tx aggregation has been enabled by the userspace tool managing
> > the qmi requests, otherwise no aggregation should be performed.
>
> Is there a specific reason why you wouldn't want to take advantage of
> aggregation that is already provided by the stack in the form of
> things such as GSO and the qdisc layer? I know most of the high speed
> NICs are always making use of xmit_more since things like GSO can take
> advantage of it to increase the throughput. Enabling BQL is a way of
> taking that one step further and enabling the non-GSO cases.
The patches had been applied last night by DaveM but FWIW I think
Alex's idea is quite interesting. Even without BQL I believe you'd
get xmit_more set within a single GSO super-frame. TCP sends data
in chunks of 64kB, and you're only aggregating 32kB. If we could
get the same effect without any added latency and user configuration
that'd be great.
next prev parent reply other threads:[~2023-01-13 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:05 [PATCH net-next v4 0/3] add tx packets aggregation to ethtool and rmnet Daniele Palmas
2023-01-11 13:05 ` [PATCH net-next v4 1/3] ethtool: add tx aggregation parameters Daniele Palmas
2023-01-11 13:05 ` [PATCH net-next v4 2/3] net: qualcomm: rmnet: add tx packets aggregation Daniele Palmas
2023-01-12 19:41 ` Subash Abhinov Kasiviswanathan (KS)
2023-01-11 13:05 ` [PATCH net-next v4 3/3] net: qualcomm: rmnet: add ethtool support for configuring tx aggregation Daniele Palmas
2023-01-12 22:59 ` [PATCH net-next v4 0/3] add tx packets aggregation to ethtool and rmnet Alexander H Duyck
2023-01-13 15:43 ` Daniele Palmas
2023-01-13 16:16 ` Alexander Duyck
2023-01-13 16:57 ` Dave Taht
2023-01-13 19:48 ` Jakub Kicinski [this message]
2023-01-15 12:15 ` Daniele Palmas
2023-01-13 21:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113114800.357a96e2@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=alexandr.lobakin@intel.com \
--cc=bjorn@mork.no \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=dnlplm@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_stranche@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).