From: Tom Parkin <tparkin@katalix.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, saeed@kernel.org, gnault@redhat.com,
Cong Wang <cong.wang@bytedance.com>
Subject: Re: [Patch net v3 0/2] l2tp: fix race conditions in l2tp_tunnel_register()
Date: Mon, 16 Jan 2023 11:38:44 +0000 [thread overview]
Message-ID: <20230116113844.GA14720@katalix.com> (raw)
In-Reply-To: <20230114030137.672706-1-xiyou.wangcong@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Fri, Jan 13, 2023 at 19:01:35 -0800, Cong Wang wrote:
> From: Cong Wang <cong.wang@bytedance.com>
>
> This patchset contains two patches, the first one is a preparation for
> the second one which is the actual fix. Please find more details in
> each patch description.
>
> I have ran the l2tp test (https://github.com/katalix/l2tp-ktest),
> all test cases are passed.
>
> ---
> v3: preserve EEXIST errno for user-space
> v2: move IDR allocation to l2tp_tunnel_register()
>
> Cong Wang (2):
> l2tp: convert l2tp_tunnel_list to idr
> l2tp: close all race conditions in l2tp_tunnel_register()
>
> net/l2tp/l2tp_core.c | 105 +++++++++++++++++++++----------------------
> 1 file changed, 52 insertions(+), 53 deletions(-)
>
> --
> 2.34.1
>
Thanks Cong, this looks good to me now.
Reviewed-by: Tom Parkin <tparkin@katalix.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-16 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 3:01 [Patch net v3 0/2] l2tp: fix race conditions in l2tp_tunnel_register() Cong Wang
2023-01-14 3:01 ` [Patch net v3 1/2] l2tp: convert l2tp_tunnel_list to idr Cong Wang
2023-01-16 11:07 ` Guillaume Nault
2023-01-14 3:01 ` [Patch net v3 2/2] l2tp: close all race conditions in l2tp_tunnel_register() Cong Wang
2023-01-16 11:08 ` Guillaume Nault
2023-01-17 8:08 ` Eric Dumazet
2023-01-17 8:10 ` Eric Dumazet
2023-01-17 10:57 ` Guillaume Nault
2023-01-16 11:38 ` Tom Parkin [this message]
2023-01-16 13:50 ` [Patch net v3 0/2] l2tp: fix " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116113844.GA14720@katalix.com \
--to=tparkin@katalix.com \
--cc=cong.wang@bytedance.com \
--cc=gnault@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).