From: Vladimir Oltean <olteanv@gmail.com>
To: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
arun.ramadoss@microchip.com, hkallweit1@gmail.com,
linux@armlinux.org.uk
Subject: Re: [PATCH net 1/2] net: dsa: microchip: ksz9477: port map correction in ALU table entry register
Date: Mon, 16 Jan 2023 22:59:45 +0200 [thread overview]
Message-ID: <20230116205945.fewkozezdxrzhwzs@skbuf> (raw)
In-Reply-To: <20230116100500.614444-2-rakesh.sankaranarayanan@microchip.com> <20230116100500.614444-2-rakesh.sankaranarayanan@microchip.com>
On Mon, Jan 16, 2023 at 03:34:59PM +0530, Rakesh Sankaranarayanan wrote:
> ALU table entry 2 register in KSZ9477 have bit positions reserved for
> forwarding port map. This field is referred in ksz9477_fdb_del() for
> clearing forward port map and alu table.
>
> But current fdb_del refer ALU table entry 3 register for accessing forward
> port map. Update ksz9477_fdb_del() to get forward port map from correct
> alu table entry register.
>
> With this bug, issue can be observed while deleting static MAC entries.
> Delete any specific MAC entry using "bridge fdb del" command. This should
> clear all the specified MAC entries. But it is observed that entries with
> self static alone are retained.
>
> Tested on LAN9370 EVB since ksz9477_fdb_del() is used common across
> LAN937x and KSZ series.
>
> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
> Signed-off-by: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Would be nice to convert the alu_table[] array into a proper structure
in a net-next patch.
next prev parent reply other threads:[~2023-01-16 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:04 [PATCH net 0/2] phy init update and alu table correction Rakesh Sankaranarayanan
2023-01-16 10:04 ` [PATCH net 1/2] net: dsa: microchip: ksz9477: port map correction in ALU table entry register Rakesh Sankaranarayanan
2023-01-16 20:59 ` Vladimir Oltean [this message]
2023-01-16 10:05 ` [PATCH net 2/2] net: dsa: microchip: lan937x: run phy initialization during each link update Rakesh Sankaranarayanan
2023-01-16 22:26 ` Vladimir Oltean
2023-01-19 11:34 ` Rakesh.Sankaranarayanan
2023-01-19 11:36 ` Vladimir Oltean
2023-01-19 17:27 ` Andrew Lunn
2023-01-19 17:35 ` Jakub Kicinski
2023-01-20 10:19 ` Rakesh.Sankaranarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116205945.fewkozezdxrzhwzs@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rakesh.sankaranarayanan@microchip.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox