From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62616C38147 for ; Wed, 18 Jan 2023 03:52:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbjARDw0 (ORCPT ); Tue, 17 Jan 2023 22:52:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjARDwY (ORCPT ); Tue, 17 Jan 2023 22:52:24 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A0B3539A2; Tue, 17 Jan 2023 19:52:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13B1B6160E; Wed, 18 Jan 2023 03:52:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD745C433EF; Wed, 18 Jan 2023 03:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674013943; bh=i1VadpNoM63eIKc7YafNwYDH8B99ORLDSioJAK/BE34=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HDk0iKijFpSBLtz3BzGz2gHS39W7dDBI6e1g87u3c76MWEiajL/rG53MwSrXRcGPo eBDoU3QWobNd1lSOjZLCkyatWD2jErwr4ymEu2P170FVF2RM+y5Y+arLXdgixLJBUj S5o/rmMbY17BRX55IBzNqREEz4rETV/4JP8YL16pxw191u6DYZjXNGT45Pbn0O5GnM 66l/wT5WoGIiCHWU18Uv48dl5FOd/+6P2obICQyKhd9Oa/dyMBUm2JQk3lNzE8DBnE nR1CFo3hkWdiuIQTRnyWQ/TGUpr8bZanDFzfOtWkhRk7btRBvJZhLL7pNgZ3bcky3F gADgcuIFHDZ4Q== Date: Tue, 17 Jan 2023 19:52:21 -0800 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Michal Kubecek , Claudiu Manoil , Vinicius Costa Gomes , Xiaoliang Yang , Kurt Kanzenbach , Rui Sousa , Ferenc Fejes , Pranavi Somisetty , Harini Katakam , Colin Foster , UNGLinuxDriver@microchip.com, Alexandre Belloni , Andrew Lunn , Florian Fainelli Subject: Re: [PATCH v3 net-next 12/12] net: mscc: ocelot: add MAC Merge layer support for VSC9959 Message-ID: <20230117195221.3e216f90@kernel.org> In-Reply-To: <20230117085947.2176464-13-vladimir.oltean@nxp.com> References: <20230117085947.2176464-1-vladimir.oltean@nxp.com> <20230117085947.2176464-13-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 17 Jan 2023 10:59:47 +0200 Vladimir Oltean wrote: > Felix (VSC9959) has a DEV_GMII:MM_CONFIG block composed of 2 registers > (ENABLE_CONFIG and VERIF_CONFIG). Because the MAC Merge statistics and > pMAC statistics are already in the Ocelot switch lib even if just Felix > supports them, I'm adding support for the whole MAC Merge layer in the > common Ocelot library too. > > There is an interrupt (shared with the PTP interrupt) which signals > changes to the MM verification state. This is done because the > preemptible traffic classes should be committed to hardware only once > the verification procedure has declared the link partner of being > capable of receiving preemptible frames. > > We implement ethtool getters and setters for the MAC Merge layer state. > The "TX enabled" and "verify status" are taken from the IRQ handler, > using a mutex to ensure serialized access. Doesn't build now.