From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E5AC004D4 for ; Wed, 18 Jan 2023 08:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbjARIwp (ORCPT ); Wed, 18 Jan 2023 03:52:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjARIwX (ORCPT ); Wed, 18 Jan 2023 03:52:23 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A905DC04 for ; Wed, 18 Jan 2023 00:04:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BED02B81B9A for ; Wed, 18 Jan 2023 08:04:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47BEBC433EF; Wed, 18 Jan 2023 08:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674029069; bh=qtSswc2uaxTuNVcL2so6pCr2nT40luVp6eTTIf3XbSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SoOiOGKFtHV1s95XyGQpgBHl/6AuhH+RqEDT5x7X2hAdi16/r7uc4ztZYK05jF9V+ HUB9iCwT1/kgDP6cR8QtJqfEFObX6xo5V31zpb7mH5vH0bDQmyYq5WIoCOOynoA1Z8 PlDPFRUybpA+TrsKho/FeHIOkDDN3UqeaPLZ+591ws/tj2l2qVg2Bk4QA6a+MMB8H6 3T/3azugOOX/CCNnnlmYUP7RQv3eifevROXkfE/epNQk97bH7hd9CLxOwW+f1HqiZK BTQrwjETtP4Y8FDzqq3NrThGrVckxAEegIePSKsQVuJ106hNBUv1cprnChDGy61wbc c4MJExKzVuxIA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Yang Yingliang , kernel test robot , Dan Carpenter , Shay Drory Subject: [net 01/10] net/mlx5: fix missing mutex_unlock in mlx5_fw_fatal_reporter_err_work() Date: Wed, 18 Jan 2023 00:04:05 -0800 Message-Id: <20230118080414.77902-2-saeed@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230118080414.77902-1-saeed@kernel.org> References: <20230118080414.77902-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Yingliang Add missing mutex_unlock() before returning from mlx5_fw_fatal_reporter_err_work(). Fixes: 9078e843efec ("net/mlx5: Avoid recovery in probe flows") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Yang Yingliang Signed-off-by: Shay Drory Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c index 96417c5feed7..879555ba847d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c @@ -677,6 +677,7 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work) mutex_lock(&dev->intf_state_mutex); if (test_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags)) { mlx5_core_err(dev, "health works are not permitted at this stage\n"); + mutex_unlock(&dev->intf_state_mutex); return; } mutex_unlock(&dev->intf_state_mutex); -- 2.39.0