netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Yanchao Yang <yanchao.yang@mediatek.com>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev ML <netdev@vger.kernel.org>,
	kernel ML <linux-kernel@vger.kernel.org>,
	Intel experts <linuxwwan@intel.com>,
	Chetan <m.chetan.kumar@intel.com>,
	MTK ML <linux-mediatek@lists.infradead.org>,
	Liang Lu <liang.lu@mediatek.com>,
	Haijun Liu <haijun.liu@mediatek.com>,
	Hua Yang <hua.yang@mediatek.com>,
	Ting Wang <ting.wang@mediatek.com>,
	Felix Chen <felix.chen@mediatek.com>,
	Mingliang Xu <mingliang.xu@mediatek.com>,
	Min Dong <min.dong@mediatek.com>,
	Aiden Wang <aiden.wang@mediatek.com>,
	Guohao Zhang <guohao.zhang@mediatek.com>,
	Chris Feng <chris.feng@mediatek.com>,
	Lambert Wang <lambert.wang@mediatek.com>,
	Mingchuang Qiao <mingchuang.qiao@mediatek.com>,
	Xiayu Zhang <xiayu.zhang@mediatek.com>,
	Haozhe Chang <haozhe.chang@mediatek.com>
Subject: Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer
Date: Thu, 19 Jan 2023 19:52:10 -0800	[thread overview]
Message-ID: <20230119195210.03537a93@kernel.org> (raw)
In-Reply-To: <20230118113859.175836-9-yanchao.yang@mediatek.com>

On Wed, 18 Jan 2023 19:38:55 +0800 Yanchao Yang wrote:
>  drivers/net/wwan/mediatek/mtk_dpmaif.c     | 4005 ++++++++++++++++++++

clang detects out-of-bound memcpy/strcpy or such somewhere in this file.
Please fix that.

Please try to make the series smaller than 17,770 :/
Strip stuff down to minimal working version.
I don't think anyone can review 17kLoC in one sitting :/

  reply	other threads:[~2023-01-20  4:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 11:38 [PATCH net-next v2 00/12] net: wwan: tmi: PCIe driver for MediaTek M.2 modem Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 01/12] net: wwan: tmi: Add PCIe core Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 02/12] net: wwan: tmi: Add control plane transaction layer Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 03/12] net: wwan: tmi: Add control DMA interface Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 04/12] net: wwan: tmi: Add control port Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 05/12] net: wwan: tmi: Add FSM thread Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 06/12] net: wwan: tmi: Add AT & MBIM WWAN ports Yanchao Yang
2023-01-21 21:46   ` kernel test robot
2023-01-18 11:38 ` [PATCH net-next v2 07/12] net: wwan: tmi: Introduce data plane hardware interface Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer Yanchao Yang
2023-01-20  3:52   ` Jakub Kicinski [this message]
2023-01-29  8:51     ` Yanchao Yang (杨彦超)
2023-01-18 11:38 ` [PATCH net-next v2 09/12] net: wwan: tmi: Introduce WWAN interface Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 10/12] net: wwan: tmi: Add exception handling service Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 11/12] net: wwan: tmi: Add power management support Yanchao Yang
2023-01-18 11:38 ` [PATCH net-next v2 12/12] net: wwan: tmi: Add maintainers and documentation Yanchao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119195210.03537a93@kernel.org \
    --to=kuba@kernel.org \
    --cc=aiden.wang@mediatek.com \
    --cc=chris.feng@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=felix.chen@mediatek.com \
    --cc=guohao.zhang@mediatek.com \
    --cc=haijun.liu@mediatek.com \
    --cc=haozhe.chang@mediatek.com \
    --cc=hua.yang@mediatek.com \
    --cc=johannes@sipsolutions.net \
    --cc=lambert.wang@mediatek.com \
    --cc=liang.lu@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linuxwwan@intel.com \
    --cc=loic.poulain@linaro.org \
    --cc=m.chetan.kumar@intel.com \
    --cc=min.dong@mediatek.com \
    --cc=mingchuang.qiao@mediatek.com \
    --cc=mingliang.xu@mediatek.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=ting.wang@mediatek.com \
    --cc=xiayu.zhang@mediatek.com \
    --cc=yanchao.yang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).