From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: nikhil.gupta@nxp.com
Cc: linux-arm-kernel@lists.infradead.org,
Yangbo Lu <yangbo.lu@nxp.com>,
richardcochran@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, vakul.garg@nxp.com,
rajan.gupta@nxp.com
Subject: Re: [PATCH v2] ptp_qoriq: fix latency in ptp_qoriq_adjtime() operation
Date: Fri, 20 Jan 2023 00:53:01 +0200 [thread overview]
Message-ID: <20230119225301.tjf5cxaigokho4nf@skbuf> (raw)
In-Reply-To: <20230119204034.7969-1-nikhil.gupta@nxp.com> <20230119204034.7969-1-nikhil.gupta@nxp.com>
On Fri, Jan 20, 2023 at 02:10:34AM +0530, nikhil.gupta@nxp.com wrote:
> From: Nikhil Gupta <nikhil.gupta@nxp.com>
>
> 1588 driver loses about 1us in adjtime operation at PTP slave
> This is because adjtime operation uses a slow non-atomic tmr_cnt_read()
> followed by tmr_cnt_write() operation.
>
> In the above sequence, since the timer counter operation keeps
> incrementing, it leads to latency. The tmr_offset register
> (which is added to TMR_CNT_H/L register giving the current time)
> must be programmed with the delta nanoseconds.
>
> Signed-off-by: Nikhil Gupta <nikhil.gupta@nxp.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
One detail regarding the process: you should have clarified your
expectations, i.e. the patch should have explicitly been generated with
git send-email --subject-prefix='PATCH v2 net-next' since it is not
targeting the 'net.git' tree for bug fixes on the master branch (which
are also backported to stable trees), but rather will be included in the
pull request for the upcoming 6.3 kernel.
next prev parent reply other threads:[~2023-01-19 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 20:40 [PATCH v2] ptp_qoriq: fix latency in ptp_qoriq_adjtime() operation nikhil.gupta
2023-01-19 22:53 ` Vladimir Oltean [this message]
2023-01-21 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119225301.tjf5cxaigokho4nf@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.gupta@nxp.com \
--cc=rajan.gupta@nxp.com \
--cc=richardcochran@gmail.com \
--cc=vakul.garg@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox