From: kernel test robot <lkp@intel.com>
To: alejandro.lucero-palau@amd.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, habetsm@gmail.com, ecree.xilinx@gmail.com,
Alejandro Lucero <alejandro.lucero-palau@amd.com>
Subject: Re: [PATCH net-next 5/7] sfc: obtain device mac address based on firmware handle for ef100
Date: Fri, 20 Jan 2023 03:47:22 +0800 [thread overview]
Message-ID: <202301200333.BjjkOStI-lkp@intel.com> (raw)
In-Reply-To: <20230119113140.20208-6-alejandro.lucero-palau@amd.com>
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/alejandro-lucero-palau-amd-com/sfc-add-devlink-support-for-ef100/20230119-193440
patch link: https://lore.kernel.org/r/20230119113140.20208-6-alejandro.lucero-palau%40amd.com
patch subject: [PATCH net-next 5/7] sfc: obtain device mac address based on firmware handle for ef100
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20230120/202301200333.BjjkOStI-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/94535fc2c87743925490d5ce0573b8e9b4b2690c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review alejandro-lucero-palau-amd-com/sfc-add-devlink-support-for-ef100/20230119-193440
git checkout 94535fc2c87743925490d5ce0573b8e9b4b2690c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/sfc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/sfc/ef100_nic.c:1127:21: warning: unused variable 'net_dev' [-Wunused-variable]
struct net_device *net_dev = efx->net_dev;
^
>> drivers/net/ethernet/sfc/ef100_nic.c:1172:9: warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
return rc;
^~
drivers/net/ethernet/sfc/ef100_nic.c:1128:8: note: initialize the variable 'rc' to silence this warning
int rc;
^
= 0
2 warnings generated.
vim +/net_dev +1127 drivers/net/ethernet/sfc/ef100_nic.c
51b35a454efdcd Edward Cree 2020-07-27 1123
98ff4c7c8ac7f5 Jonathan Cooper 2022-06-28 1124 int ef100_probe_netdev_pf(struct efx_nic *efx)
51b35a454efdcd Edward Cree 2020-07-27 1125 {
98ff4c7c8ac7f5 Jonathan Cooper 2022-06-28 1126 struct ef100_nic_data *nic_data = efx->nic_data;
29ec1b27e73990 Edward Cree 2020-07-27 @1127 struct net_device *net_dev = efx->net_dev;
98ff4c7c8ac7f5 Jonathan Cooper 2022-06-28 1128 int rc;
29ec1b27e73990 Edward Cree 2020-07-27 1129
6f6838aabff5ea Edward Cree 2022-07-28 1130 if (!nic_data->grp_mae)
6f6838aabff5ea Edward Cree 2022-07-28 1131 return 0;
6f6838aabff5ea Edward Cree 2022-07-28 1132
6f6838aabff5ea Edward Cree 2022-07-28 1133 #ifdef CONFIG_SFC_SRIOV
67ab160ed08f5b Edward Cree 2022-07-28 1134 rc = efx_init_struct_tc(efx);
67ab160ed08f5b Edward Cree 2022-07-28 1135 if (rc)
67ab160ed08f5b Edward Cree 2022-07-28 1136 return rc;
67ab160ed08f5b Edward Cree 2022-07-28 1137
6f6838aabff5ea Edward Cree 2022-07-28 1138 rc = efx_ef100_get_base_mport(efx);
6f6838aabff5ea Edward Cree 2022-07-28 1139 if (rc) {
6f6838aabff5ea Edward Cree 2022-07-28 1140 netif_warn(efx, probe, net_dev,
6f6838aabff5ea Edward Cree 2022-07-28 1141 "Failed to probe base mport rc %d; representors will not function\n",
6f6838aabff5ea Edward Cree 2022-07-28 1142 rc);
f393f2642abb0e Alejandro Lucero 2023-01-19 1143 } else {
f393f2642abb0e Alejandro Lucero 2023-01-19 1144 if (efx_probe_devlink(efx))
f393f2642abb0e Alejandro Lucero 2023-01-19 1145 netif_warn(efx, probe, net_dev,
f393f2642abb0e Alejandro Lucero 2023-01-19 1146 "Failed to register devlink\n");
1542af777ce523 Alejandro Lucero 2023-01-19 1147 rc = efx_init_mae(efx);
1542af777ce523 Alejandro Lucero 2023-01-19 1148 if (rc)
1542af777ce523 Alejandro Lucero 2023-01-19 1149 pci_warn(efx->pci_dev,
1542af777ce523 Alejandro Lucero 2023-01-19 1150 "Failed to init MAE rc %d; representors will not function\n",
1542af777ce523 Alejandro Lucero 2023-01-19 1151 rc);
1542af777ce523 Alejandro Lucero 2023-01-19 1152 else
1542af777ce523 Alejandro Lucero 2023-01-19 1153 efx_ef100_init_reps(efx);
6f6838aabff5ea Edward Cree 2022-07-28 1154 }
67ab160ed08f5b Edward Cree 2022-07-28 1155
67ab160ed08f5b Edward Cree 2022-07-28 1156 rc = efx_init_tc(efx);
67ab160ed08f5b Edward Cree 2022-07-28 1157 if (rc) {
67ab160ed08f5b Edward Cree 2022-07-28 1158 /* Either we don't have an MAE at all (i.e. legacy v-switching),
67ab160ed08f5b Edward Cree 2022-07-28 1159 * or we do but we failed to probe it. In the latter case, we
67ab160ed08f5b Edward Cree 2022-07-28 1160 * may not have set up default rules, in which case we won't be
67ab160ed08f5b Edward Cree 2022-07-28 1161 * able to pass any traffic. However, we don't fail the probe,
67ab160ed08f5b Edward Cree 2022-07-28 1162 * because the user might need to use the netdevice to apply
67ab160ed08f5b Edward Cree 2022-07-28 1163 * configuration changes to fix whatever's wrong with the MAE.
67ab160ed08f5b Edward Cree 2022-07-28 1164 */
67ab160ed08f5b Edward Cree 2022-07-28 1165 netif_warn(efx, probe, net_dev, "Failed to probe MAE rc %d\n",
67ab160ed08f5b Edward Cree 2022-07-28 1166 rc);
9dc0cad203ab57 Edward Cree 2022-09-26 1167 } else {
9dc0cad203ab57 Edward Cree 2022-09-26 1168 net_dev->features |= NETIF_F_HW_TC;
9dc0cad203ab57 Edward Cree 2022-09-26 1169 efx->fixed_features |= NETIF_F_HW_TC;
67ab160ed08f5b Edward Cree 2022-07-28 1170 }
6f6838aabff5ea Edward Cree 2022-07-28 1171 #endif
29ec1b27e73990 Edward Cree 2020-07-27 @1172 return rc;
51b35a454efdcd Edward Cree 2020-07-27 1173 }
51b35a454efdcd Edward Cree 2020-07-27 1174
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-01-19 19:48 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 11:31 [PATCH net-next 0/7] sfc: devlink support for ef100 alejandro.lucero-palau
2023-01-19 11:31 ` [PATCH net-next 1/7] sfc: add " alejandro.lucero-palau
2023-01-19 12:14 ` Jiri Pirko
2023-01-19 14:51 ` Lucero Palau, Alejandro
2023-01-19 16:29 ` Lucero Palau, Alejandro
2023-01-20 11:02 ` Jiri Pirko
2023-01-20 11:00 ` Jiri Pirko
2023-01-19 15:50 ` kernel test robot
2023-01-19 17:16 ` Jakub Kicinski
2023-01-19 17:52 ` Lucero Palau, Alejandro
2023-01-19 18:44 ` Jakub Kicinski
2023-01-19 19:08 ` Lucero Palau, Alejandro
2023-01-19 23:40 ` Jacob Keller
2023-01-20 14:11 ` Lucero Palau, Alejandro
2023-01-24 6:13 ` Edward Cree
2023-01-24 7:31 ` Lucero Palau, Alejandro
2023-01-24 11:05 ` Lucero Palau, Alejandro
2023-01-24 22:12 ` Jacob Keller
2023-01-20 13:59 ` kernel test robot
2023-01-19 11:31 ` [PATCH net-next 2/7] sfc: enumerate mports in ef100 alejandro.lucero-palau
2023-01-19 23:48 ` Jacob Keller
2023-01-20 14:13 ` Lucero Palau, Alejandro
2023-01-20 12:47 ` kernel test robot
2023-01-19 11:31 ` [PATCH net-next 3/7] sfc: add mport lookup based on driver's mport data alejandro.lucero-palau
2023-01-19 23:57 ` Jacob Keller
2023-01-20 9:34 ` Lucero Palau, Alejandro
2023-01-20 18:36 ` Keller, Jacob E
2023-01-19 11:31 ` [PATCH net-next 4/7] sfc: add devlink port support for ef100 alejandro.lucero-palau
2023-01-19 12:33 ` Jiri Pirko
2023-01-19 15:03 ` Lucero Palau, Alejandro
2023-01-19 13:37 ` kernel test robot
2023-01-20 21:21 ` kernel test robot
2023-01-19 11:31 ` [PATCH net-next 5/7] sfc: obtain device mac address based on firmware handle " alejandro.lucero-palau
2023-01-19 19:47 ` kernel test robot [this message]
2023-01-20 0:03 ` Jacob Keller
2023-01-19 11:31 ` [PATCH net-next 6/7] sfc: add support for port_function_hw_addr_get devlink in ef100 alejandro.lucero-palau
2023-01-19 12:25 ` Jiri Pirko
2023-01-19 14:59 ` Lucero Palau, Alejandro
2023-01-20 11:05 ` Jiri Pirko
2023-01-22 16:41 ` Lucero Palau, Alejandro
2023-01-19 12:37 ` Jiri Pirko
2023-01-19 15:09 ` Lucero Palau, Alejandro
2023-01-20 11:08 ` Jiri Pirko
2023-01-20 12:48 ` Lucero Palau, Alejandro
2023-01-22 16:36 ` Lucero Palau, Alejandro
2023-01-23 8:38 ` Jiri Pirko
2023-01-23 9:45 ` Lucero Palau, Alejandro
2023-01-23 10:18 ` Jiri Pirko
2023-01-19 11:31 ` [PATCH net-next 7/7] sfc: add support for devlink port_function_hw_addr_set " alejandro.lucero-palau
2023-01-19 12:27 ` Jiri Pirko
2023-01-19 15:10 ` Lucero Palau, Alejandro
2023-01-20 8:55 ` [PATCH net-next 0/7] sfc: devlink support for ef100 Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301200333.BjjkOStI-lkp@intel.com \
--to=lkp@intel.com \
--cc=alejandro.lucero-palau@amd.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).