From: Jakub Kicinski <kuba@kernel.org>
To: Eli Cohen <elic@nvidia.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"Parav Pandit" <parav@nvidia.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, "Jason Wang" <jasowang@redhat.com>,
"Gautam Dawar" <gautam.dawar@xilinx.com>,
"Cindy Lu" <lulu@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eugenio Pérez" <eperezma@redhat.com>
Subject: Re: [PATCH 1/4] virtio_net: notify MAC address change on device initialization
Date: Mon, 23 Jan 2023 19:31:14 -0800 [thread overview]
Message-ID: <20230123193114.56aaec3a@kernel.org> (raw)
In-Reply-To: <07a24753-767b-4e1e-2bcf-21ec04bc044a@nvidia.com>
On Sun, 22 Jan 2023 15:47:08 +0200 Eli Cohen wrote:
> > @@ -3956,6 +3958,18 @@ static int virtnet_probe(struct virtio_device *vdev)
> > pr_debug("virtnet: registered device %s with %d RX and TX vq's\n",
> > dev->name, max_queue_pairs);
> >
> > + /* a random MAC address has been assigned, notify the device */
> > + if (dev->addr_assign_type == NET_ADDR_RANDOM &&
> Maybe it's better to not count on addr_assign_type and use a local
> variable to indicate that virtnet_probe assigned random MAC.
+1, FWIW
next prev parent reply other threads:[~2023-01-24 3:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 10:05 [PATCH 0/4] virtio_net: vdpa: update MAC address when it is generated by virtio-net Laurent Vivier
2023-01-22 10:05 ` [PATCH 1/4] virtio_net: notify MAC address change on device initialization Laurent Vivier
2023-01-22 13:47 ` Eli Cohen
2023-01-23 9:52 ` Laurent Vivier
2023-01-23 10:05 ` Eli Cohen
2023-01-24 3:31 ` Jakub Kicinski [this message]
2023-01-24 7:19 ` Laurent Vivier
2023-01-22 10:05 ` [PATCH 2/4] virtio_net: add a timeout in virtnet_send_command() Laurent Vivier
2023-01-22 10:05 ` [PATCH 3/4] vdpa_sim_net: don't always set VIRTIO_NET_F_MAC Laurent Vivier
2023-01-22 10:05 ` [PATCH 4/4] virtio_net: fix virtnet_send_command() with vdpa_sim_net Laurent Vivier
2023-01-22 10:23 ` [PATCH 0/4] virtio_net: vdpa: update MAC address when it is generated by virtio-net Michael S. Tsirkin
2023-01-23 9:25 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123193114.56aaec3a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gautam.dawar@xilinx.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).