From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH net-next] net: ethtool: fix NULL pointer dereference in stats_prepare_data()
Date: Tue, 24 Jan 2023 17:17:36 -0800 [thread overview]
Message-ID: <20230124171736.30729264@kernel.org> (raw)
In-Reply-To: <20230125005333.dmphl4vuwnh66moa@skbuf>
On Wed, 25 Jan 2023 02:53:33 +0200 Vladimir Oltean wrote:
> > > Yeah, sorry, I shouldn't have left your question unanswered ("should we make
> > > a fake struct genl_info * to pass here?") - but I don't think I'm qualified
> > > enough to have an opinion, either. Whereas the immediate fix is neutral
> > > enough to not be controversial, or so I thought.
> > >
> > > The problem is not so much "the time to fix this properly", but rather,
> > > I'm not even sure how to trigger the ethtool dumpit() code...
> >
> > Ack, makes sense. I just wanted to make sure you weren't disagreeing.
>
> Since we're talking about it, do you know how to exercise that code?
Your MM code? Not really. But the code is fairly copy'n'paste.
I test what netdevsim supports (netdevsim support for MM highly
encouraged).
next prev parent reply other threads:[~2023-01-25 1:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 11:08 [PATCH net-next] net: ethtool: fix NULL pointer dereference in stats_prepare_data() Vladimir Oltean
2023-01-24 12:28 ` Leon Romanovsky
2023-01-25 0:23 ` Jakub Kicinski
2023-01-25 0:45 ` Vladimir Oltean
2023-01-25 0:52 ` Jakub Kicinski
2023-01-25 0:53 ` Vladimir Oltean
2023-01-25 1:17 ` Jakub Kicinski [this message]
2023-01-25 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124171736.30729264@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).