From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@kernel.org>
Cc: Shawn Bohrer <sbohrer@cloudflare.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
makita.toshiaki@lab.ntt.co.jp
Subject: Re: KASAN veth use after free in XDP_REDIRECT
Date: Tue, 24 Jan 2023 18:02:35 -0800 [thread overview]
Message-ID: <20230124180230.23ff309e@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <87357znztf.fsf@toke.dk>
On Wed, 25 Jan 2023 02:54:52 +0100 Toke Høiland-Jørgensen wrote:
> However, because the skb->head in this case was allocated from a slab
> allocator, taking a page refcount is not enough to prevent it from being
> freed.
>
> I'm not sure how best to fix this. I guess we could try to detect this
> case in the veth driver and copy the data, like we do for skb_share()
> etc. However, I'm not sure how to actually detect this case...
sbk->head_frag ?
next prev parent reply other threads:[~2023-01-25 2:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 22:45 KASAN veth use after free in XDP_REDIRECT Shawn Bohrer
2023-01-25 1:54 ` Toke Høiland-Jørgensen
2023-01-25 2:02 ` Jakub Kicinski [this message]
2023-01-25 2:07 ` Toshiaki Makita
2023-03-08 22:33 ` Shawn Bohrer
2023-03-14 8:02 ` Toshiaki Makita
2023-03-14 15:25 ` Shawn Bohrer
2023-03-14 15:33 ` [PATCH] veth: Fix " Shawn Bohrer
2023-03-14 17:13 ` Lorenzo Bianconi
2023-03-15 6:19 ` Toshiaki Makita
2023-03-15 18:08 ` Toke Høiland-Jørgensen
2023-03-16 4:20 ` patchwork-bot+netdevbpf
2023-01-25 16:40 ` KASAN veth " Shawn Bohrer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124180230.23ff309e@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=sbohrer@cloudflare.com \
--cc=toke@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox