From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, michael.chan@broadcom.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
tariqt@nvidia.com, saeedm@nvidia.com, leon@kernel.org,
idosch@nvidia.com, petrm@nvidia.com, simon.horman@corigine.com,
aelior@marvell.com, manishc@marvell.com,
jacob.e.keller@intel.com, gal@nvidia.com,
yinjun.zhang@corigine.com, fei.qin@corigine.com,
Niklas.Cassel@wdc.com
Subject: Re: [patch net-next 00/12] devlink: Cleanup params usage
Date: Wed, 25 Jan 2023 09:49:44 -0800 [thread overview]
Message-ID: <20230125094944.5e362b76@kernel.org> (raw)
In-Reply-To: <20230125141412.1592256-1-jiri@resnulli.us>
On Wed, 25 Jan 2023 15:14:00 +0100 Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> This patchset takes care of small cleanup of devlink params usage.
> Some of the patches (first 2/3) are cosmetic, but I would like to
> point couple of interesting ones:
>
> Patch 9 is the main one of this set and introduces devlink instance
> locking for params, similar to other devlink objects. That allows params
> to be registered/unregistered when devlink instance is registered.
>
> Patches 10-12 change mlx5 code to register non-driverinit params in the
> code they are related to, and thanks to patch 8 this might be when
> devlink instance is registered - for example during devlink reload.
For the first 9:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Thanks!
next prev parent reply other threads:[~2023-01-25 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 14:14 [patch net-next 00/12] devlink: Cleanup params usage Jiri Pirko
2023-01-25 14:14 ` [patch net-next 01/12] net/mlx5: Change devlink param register/unregister function names Jiri Pirko
2023-01-25 14:14 ` [patch net-next 02/12] net/mlx5: Covert devlink params registration to use devlink_params_register/unregister() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 03/12] devlink: make devlink_param_register/unregister static Jiri Pirko
2023-01-25 14:14 ` [patch net-next 04/12] devlink: don't work with possible NULL pointer in devlink_param_unregister() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 05/12] ice: remove pointless calls to devlink_param_driverinit_value_set() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 06/12] qed: remove pointless call " Jiri Pirko
2023-01-25 14:14 ` [patch net-next 07/12] devlink: make devlink_param_driverinit_value_set() return void Jiri Pirko
2023-01-25 14:14 ` [patch net-next 08/12] devlink: put couple of WARN_ONs in devlink_param_driverinit_value_get() Jiri Pirko
2023-01-25 14:14 ` [patch net-next 09/12] devlink: protect devlink param list by instance lock Jiri Pirko
2023-01-26 7:50 ` Ido Schimmel
2023-01-25 14:14 ` [patch net-next 10/12] net/mlx5: Move fw reset devlink param to fw reset code Jiri Pirko
2023-01-25 14:14 ` [patch net-next 11/12] net/mlx5: Move flow steering devlink param to flow steering code Jiri Pirko
2023-01-25 14:14 ` [patch net-next 12/12] net/mlx5: Move eswitch port metadata devlink param to flow eswitch code Jiri Pirko
2023-01-25 17:40 ` Jiri Pirko
2023-01-25 17:49 ` Jakub Kicinski [this message]
2023-01-25 18:13 ` [patch net-next 00/12] devlink: Cleanup params usage Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125094944.5e362b76@kernel.org \
--to=kuba@kernel.org \
--cc=Niklas.Cassel@wdc.com \
--cc=aelior@marvell.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fei.qin@corigine.com \
--cc=gal@nvidia.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=manishc@marvell.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=tariqt@nvidia.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).