From: Rob Herring <robh@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andrey Konovalov <andrey.konovalov@linaro.org>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org,
alexandre.torgue@foss.st.com, peppe.cavallaro@st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] net: stmmac: add DT parameter to keep RX_CLK running in LPI state
Date: Wed, 25 Jan 2023 13:14:53 -0600 [thread overview]
Message-ID: <20230125191453.GA2704119-robh@kernel.org> (raw)
In-Reply-To: <Y8/mrhWDa6DuauZY@lunn.ch>
On Tue, Jan 24, 2023 at 03:09:50PM +0100, Andrew Lunn wrote:
> > > Could
> > > dwmac-qcom-ethqos.c just do this unconditionally?
> >
> > Never stopping RX_CLK in Rx LPI state would always work, but the power
> > consumption would somewhat increase (in Rx LPI state). Some people do care
> > about it.
> >
> > > Is the interrupt
> > > controller part of the licensed IP, or is it from QCOM? If it is part
> > > of the licensed IP, it is probably broken for other devices as well,
> > > so maybe it should be a quirk for all devices of a particular version
> > > of the IP?
> >
> > Most probably this is the part of the ethernet MAC IP. And this is quite
> > possible that the issue is specific for particular versions of the IP.
> > Unfortunately I don't have the documentation related to this particular
> > issue.
>
> Please could you ask around. Do you have contacts in Qualcomm?
> Contacts at Synopsys?
>
> Ideally it would be nice to fix it for everybody, not just one SoC.
Yes, but to fix for just 1 SoC use the SoC specific compatible to imply
the need for this. Then only a kernel update is needed to fix, not a
kernel and dtb update.
Rob
next prev parent reply other threads:[~2023-01-25 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:37 [PATCH 0/2] net: stmmac: add DT parameter to keep RX_CLK running in LPI state Andrey Konovalov
2023-01-23 13:37 ` [PATCH 1/2] dt-bindings: net: snps,dwmac: add snps,rx-clk-runs-in-lpi parameter Andrey Konovalov
2023-01-23 13:37 ` [PATCH 2/2] net: stmmac: consider snps,rx-clk-runs-in-lpi DT parameter Andrey Konovalov
2023-01-24 1:04 ` [PATCH 0/2] net: stmmac: add DT parameter to keep RX_CLK running in LPI state Andrew Lunn
2023-01-24 8:49 ` Andrey Konovalov
2023-01-24 14:09 ` Andrew Lunn
2023-01-25 19:14 ` Rob Herring [this message]
2023-01-26 21:51 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125191453.GA2704119-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=andrey.konovalov@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).