From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
bridge@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, Nikolay Aleksandrov <razor@blackwall.org>,
Paolo Abeni <pabeni@redhat.com>, Roopa Prabhu <roopa@nvidia.com>
Subject: Re: [PATCH net-next] netlink: provide an ability to set default extack message
Date: Thu, 26 Jan 2023 23:26:15 -0800 [thread overview]
Message-ID: <20230126232615.1901128c@kernel.org> (raw)
In-Reply-To: <Y9NgdXk3NLtjG3Mj@unreal>
On Fri, 27 Jan 2023 07:26:13 +0200 Leon Romanovsky wrote:
> > That'd be my preference too, FWIW. It's only the offload cases which
> > need this sort of fallback.
>
> Of course not, almost any error unwind path which sets extack will need it.
I guess we can come up with scenarios where the new behavior would
be useful. But the fact is - your patch changes 4 places...
> See devlink as an example
I don't know what part of devlink you mean at a quick scroll.
next prev parent reply other threads:[~2023-01-27 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 19:15 [PATCH net-next] netlink: provide an ability to set default extack message Leon Romanovsky
2023-01-26 22:32 ` Vladimir Oltean
2023-01-26 22:37 ` Jakub Kicinski
2023-01-26 22:44 ` Vladimir Oltean
2023-01-26 23:39 ` Jakub Kicinski
2023-01-27 5:26 ` Leon Romanovsky
2023-01-27 7:26 ` Jakub Kicinski [this message]
2023-01-29 11:43 ` Leon Romanovsky
2023-01-27 5:22 ` Leon Romanovsky
2023-01-27 9:22 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126232615.1901128c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).