netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	virtualization@lists.linux-foundation.org,
	"Cindy Lu" <lulu@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eli Cohen" <elic@nvidia.com>,
	"Gautam Dawar" <gautam.dawar@xilinx.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	netdev@vger.kernel.org, "Parav Pandit" <parav@nvidia.com>
Subject: [PATCH v3 0/2] virtio_net: vdpa: update MAC address when it is generated by virtio-net
Date: Fri, 27 Jan 2023 21:44:58 +0100	[thread overview]
Message-ID: <20230127204500.51930-1-lvivier@redhat.com> (raw)

When the MAC address is not provided by the vdpa device virtio_net
driver assigns a random one without notifying the device.
The consequence, in the case of mlx5_vdpa, is the internal routing
tables of the device are not updated and this can block the
communication between two namespaces.

To fix this problem, use virtnet_send_command(VIRTIO_NET_CTRL_MAC)
to set the address from virtnet_probe() when the MAC address is
not provided by the device.

v3:
  - update comments
  - fail probe if VIRTIO_NET_CTRL_MAC_ADDR_SET fails
  - move the virtnet_send_command() upper, inside the RTNL lock,
    this simplifies the cleanup in case of error, and a future patch
    from Jason adds an ASSERT_RTNL() in virtnet_send_command()
    ("virtio-net: convert rx mode setting to use workqueue")
  - add a patch to disable F_STANDBY if F_MAC is not set

v2:
  - remove vdpa_sim related fixes
  - check virtio_has_feature(vdev, VIRTIO_NET_F_MAC) rather than
    addr_assign_type

Laurent Vivier (2):
  virtio_net: disable VIRTIO_NET_F_STANDBY if VIRTIO_NET_F_MAC is not
    set
  virtio_net: notify MAC address change on device initialization

 drivers/net/virtio_net.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

-- 
2.39.1


             reply	other threads:[~2023-01-27 20:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 20:44 Laurent Vivier [this message]
2023-01-27 20:44 ` [PATCH v3 1/2] virtio_net: disable VIRTIO_NET_F_STANDBY if VIRTIO_NET_F_MAC is not set Laurent Vivier
2023-01-31 22:09   ` Michael S. Tsirkin
2023-01-27 20:45 ` [PATCH v3 2/2] virtio_net: notify MAC address change on device initialization Laurent Vivier
2023-01-31  9:01   ` Paolo Abeni
2023-01-31  9:32     ` Laurent Vivier
2023-01-31 11:41       ` Paolo Abeni
2023-01-31 13:43     ` Michael S. Tsirkin
2023-01-31 14:40       ` Paolo Abeni
2023-01-31 22:09   ` Michael S. Tsirkin
2023-02-02  5:00 ` [PATCH v3 0/2] virtio_net: vdpa: update MAC address when it is generated by virtio-net patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230127204500.51930-1-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=davem@davemloft.net \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=gautam.dawar@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).