From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69399C61DA4 for ; Mon, 30 Jan 2023 09:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236243AbjA3J4H (ORCPT ); Mon, 30 Jan 2023 04:56:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236382AbjA3Jzt (ORCPT ); Mon, 30 Jan 2023 04:55:49 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D82032F7AC; Mon, 30 Jan 2023 01:55:25 -0800 (PST) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BE88C20009; Mon, 30 Jan 2023 09:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1675072514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D1q99COeEhSgAwyVTxW/RO7yjBL/O8JQ1iE+OT9BH0A=; b=QIN7FUYzn0dtmRGBp0w2TVIW7uDeHwZcmXcfcPutBehGK13ZbLZKEc5pwaqrF9+AJEjB3y BSKTgdxIEJa4lZZXkCNxf5mhTAX6am3nW5b6dAts/HViLKiLy5j4mQbWdE+1hL3x9oXWDS h+1LWDaCCWZNDw/HxYIFukN2VOzn+G4MRw6JD7XPqD+dbE4u8mN/B0twRfw0sjC7S9NJd1 dKiQW3oeKppfl+VvXprV05BUH64jZq2b2gFwOKgg74KT1A07t5dQ5jIuitIlAejnVsbeQs wNnLcc8+1kalJIy/UPfxEbbry1ca6EIlUSE6NfosMZkLN5gzeyCDrIO+jlcsMQ== Date: Mon, 30 Jan 2023 10:55:08 +0100 From: Miquel Raynal To: Alexander Aring Cc: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Guilhem Imberton , Thomas Petazzoni Subject: Re: [PATCH wpan-next v2 0/2] ieee802154: Beaconing support Message-ID: <20230130105508.38a25780@xps-13> In-Reply-To: References: <20230125102923.135465-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Alexander, aahringo@redhat.com wrote on Thu, 26 Jan 2023 20:48:02 -0500: > Hi, >=20 > On Thu, Jan 26, 2023 at 8:45 PM Alexander Aring wro= te: > > > > Hi, > > > > On Wed, Jan 25, 2023 at 5:31 AM Miquel Raynal wrote: =20 > > > > > > Scanning being now supported, we can eg. play with hwsim to verify > > > everything works as soon as this series including beaconing support g= ets > > > merged. > > > > > > Thanks, > > > Miqu=C3=A8l > > > > > > Changes in v2: > > > * Clearly state in the commit log llsec is not supported yet. > > > * Do not use mlme transmission helpers because we don't really need to > > > stop the queue when sending a beacon, as we don't expect any feedba= ck > > > from the PHY nor from the peers. However, we don't want to go throu= gh > > > the whole net stack either, so we bypass it calling the subif helper > > > directly. > > > =20 >=20 > moment, we use the mlme helpers to stop tx=20 No, we no longer use the mlme helpers to stop tx when sending beacons (but true MLME transmissions, we ack handling and return codes will be used for other purposes). > but we use the > ieee802154_subif_start_xmit() because of the possibility to invoke > current 802.15.4 hooks like llsec? That's how I understand it. We go through llsec (see ieee802154_subif_start_xmit() implementation) when we send data or beacons. When we send beacons, for now, we just discard the llsec logic. This needs of course to be improved. We will probably need some llsec handling in the mlme case as well in the near future. Thanks, Miqu=C3=A8l