From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6748BC63797 for ; Mon, 30 Jan 2023 19:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237345AbjA3TZk (ORCPT ); Mon, 30 Jan 2023 14:25:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237741AbjA3TZe (ORCPT ); Mon, 30 Jan 2023 14:25:34 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6021E3B66E for ; Mon, 30 Jan 2023 11:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675106731; x=1706642731; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=59EN9EBQChdyKl4CTrfzax110ZA83yJ4R82Xj66jpyA=; b=RKVUGm7CZ3gC/jo8/xU2U82WkLjYGF/ASDnCeWpAYXsBAJuJGRx1y+Qs 7ZvR4yzQKZyB+LahG611Q4kUBKjRbpwP54NwwLmrcyyetJgrNe6zL+sfC j5cb8Upw3Qivo4FCrn0KtTj593HZTjrhlm2eN6SjOP27Bbgel40C0QgVf foUL1NjCuYwj97nZ1zQ4jv3gfg3plHe/qlqjJHfuipX2LuFaFQr2A2y9I P0xl3Zrcw0+UgpEGeYfCMih7pAaK8vXSuzhgS93yMPoKkB+B4y2gi+Mmp fPqiyHrHUDxXSy9SX+SfnZkXiQsC1KRi4x7nedVXFfAgc6rvyACu/AFws Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="392198600" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="392198600" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 11:25:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="696534362" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="696534362" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orsmga001.jf.intel.com with ESMTP; 30 Jan 2023 11:25:25 -0800 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com Cc: Bjorn Helgaas , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, Gurucharan G Subject: [PATCH net-next 3/8] i40e: Remove redundant pci_enable_pcie_error_reporting() Date: Mon, 30 Jan 2023 11:25:14 -0800 Message-Id: <20230130192519.686446-4-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230130192519.686446-1-anthony.l.nguyen@intel.com> References: <20230130192519.686446-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this doesn't control interrupt generation by the Root Port; that is controlled by the AER Root Error Command register, which is managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Tested-by: Gurucharan G (A Contingent worker at Intel) Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 53d0083e35da..43693f902c27 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -15589,7 +15589,6 @@ static int i40e_init_recovery_mode(struct i40e_pf *pf, struct i40e_hw *hw) timer_shutdown_sync(&pf->service_timer); i40e_shutdown_adminq(hw); iounmap(hw->hw_addr); - pci_disable_pcie_error_reporting(pf->pdev); pci_release_mem_regions(pf->pdev); pci_disable_device(pf->pdev); kfree(pf); @@ -15660,7 +15659,6 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_pci_reg; } - pci_enable_pcie_error_reporting(pdev); pci_set_master(pdev); /* Now that we have a PCI connection, we need to do the @@ -16218,7 +16216,6 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_ioremap: kfree(pf); err_pf_alloc: - pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: @@ -16366,7 +16363,6 @@ static void i40e_remove(struct pci_dev *pdev) kfree(pf); pci_release_mem_regions(pdev); - pci_disable_pcie_error_reporting(pdev); pci_disable_device(pdev); } -- 2.38.1