From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4368EC54EAA for ; Mon, 30 Jan 2023 19:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238247AbjA3TZy (ORCPT ); Mon, 30 Jan 2023 14:25:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237342AbjA3TZg (ORCPT ); Mon, 30 Jan 2023 14:25:36 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB7062D70 for ; Mon, 30 Jan 2023 11:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675106735; x=1706642735; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zVCRyMGbm/RcCg4vezyeSOb0ioIrPkOFiSFnfEN/PqE=; b=heucPxSZQuzeHWvpHpBGvwZWanaH4dfj5w82qUWRZAA5o4NW91aQAGf/ tty+uaq1yp47Kog5zhhOJp9nev0GINQKoKqiJeIBi61zu8BPW2ZubuRBt t6o318n7tXUKhITraFpH2jPdj8DrdVTKOi93CcY0Oj4ls39x0FIK/Iwlz 91wDjbYzypITmlNJY2qsV0UB08JMRsXVHhM+UpEEwg+nJB7tWlP4TSuzx aweoCAGjKC/QwY7UYAKImc0l1l89QcCZRRu+dwZnKBr7/6fBsrc/4Z4QX ybVLlhEjSG8HH7YU40kuzTLWybMz7WjgBE0Kn/1Qip1K03h8vlpDZSujr Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="392198635" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="392198635" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 11:25:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="696534380" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="696534380" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by orsmga001.jf.intel.com with ESMTP; 30 Jan 2023 11:25:26 -0800 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com Cc: Bjorn Helgaas , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Jesse Brandeburg , intel-wired-lan@lists.osuosl.org, Gurucharan G Subject: [PATCH net-next 8/8] ixgbe: Remove redundant pci_enable_pcie_error_reporting() Date: Mon, 30 Jan 2023 11:25:19 -0800 Message-Id: <20230130192519.686446-9-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230130192519.686446-1-anthony.l.nguyen@intel.com> References: <20230130192519.686446-1-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this doesn't control interrupt generation by the Root Port; that is controlled by the AER Root Error Command register, which is managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Jesse Brandeburg Cc: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Tested-by: Gurucharan G (A Contingent worker at Intel) Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 43a44c1e1576..992b7ae75233 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -10809,8 +10809,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_pci_reg; } - pci_enable_pcie_error_reporting(pdev); - pci_set_master(pdev); pci_save_state(pdev); @@ -11238,7 +11236,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent) disable_dev = !test_and_set_bit(__IXGBE_DISABLED, &adapter->state); free_netdev(netdev); err_alloc_etherdev: - pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: @@ -11327,8 +11324,6 @@ static void ixgbe_remove(struct pci_dev *pdev) disable_dev = !test_and_set_bit(__IXGBE_DISABLED, &adapter->state); free_netdev(netdev); - pci_disable_pcie_error_reporting(pdev); - if (disable_dev) pci_disable_device(pdev); } -- 2.38.1