From: Jakub Kicinski <kuba@kernel.org>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH net-next 2/2] amd-xgbe: add support for rx-adaptation
Date: Tue, 31 Jan 2023 11:11:55 -0800 [thread overview]
Message-ID: <20230131111155.5cb607a6@kernel.org> (raw)
In-Reply-To: <c1ddd073-2494-9c8a-0f61-8330d7d6bb0c@amd.com>
On Tue, 31 Jan 2023 15:26:14 +0530 Raju Rangoju wrote:
> > Sure, I've re-ordered most of the functions correctly to avoid forward
> > declarations. However, there is circular dependency on couple of them.
> > Let us know if its fine to have forward declaration for the functions
> > that have circular-dependency.
>
> Gentle reminder!
>
> Let us know if it is okay to have forward declarations for functions
> that have circular dependency.
Yes, in case of circular dependencies there's not much we can do.
prev parent reply other threads:[~2023-01-31 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 7:25 [PATCH net-next 0/2] amd-xgbe: add support for 2.5GbE and rx-adaptation Raju Rangoju
2023-01-25 7:25 ` [PATCH net-next 1/2] amd-xgbe: add 2.5GbE support to 10G BaseT mode Raju Rangoju
2023-01-25 13:39 ` Andrew Lunn
2023-01-26 6:49 ` Raju Rangoju
2023-01-25 7:25 ` [PATCH net-next 2/2] amd-xgbe: add support for rx-adaptation Raju Rangoju
2023-01-26 7:04 ` Jakub Kicinski
2023-01-27 7:43 ` Raju Rangoju
2023-01-31 9:56 ` Raju Rangoju
2023-01-31 19:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131111155.5cb607a6@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).