From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A666FC38142
	for <netdev@archiver.kernel.org>; Tue, 31 Jan 2023 19:12:22 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230295AbjAaTMV (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 31 Jan 2023 14:12:21 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60352 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230306AbjAaTMT (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 31 Jan 2023 14:12:19 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B21F456490
        for <netdev@vger.kernel.org>; Tue, 31 Jan 2023 11:11:59 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 63591B81E3B
        for <netdev@vger.kernel.org>; Tue, 31 Jan 2023 19:11:58 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2045C433D2;
        Tue, 31 Jan 2023 19:11:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1675192317;
        bh=wFxmLnpBqIFP8bY8MbUFOLTpD00oM5wLOM3MfGeTgj4=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=R1BjmzRrgEFgvp09f22OEKxHFSRWzrnADV0WaWWjj0tM8Gm2wRKf1lzKtbYAIRoWx
         c9CTVmGoSjBs7vBr/IjlJ+iBboUe4gMDbN1waO8LT/zJYBFttqacVLEpSMI8E7hiwv
         HETltLzZC6HpR49iROxFZihOgqe6xIFhegEcPxn19SrawE82jaHkk58tPKXG+YLg7b
         Iob9gFSXEpzJqxpP/OHzVcWh70+QsSSsYoDogq4ywPd5hHbKx50WVmmqzVJQJG+u5J
         YgkkQ8VcqcbAfl/+F0ax/7kBz8SDYKbJ8eULmScL2quUjNzqJu44Z/piIG/h2wjSWZ
         QQNQPp+wSJv2w==
Date:   Tue, 31 Jan 2023 11:11:55 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Raju Rangoju <Raju.Rangoju@amd.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH net-next 2/2] amd-xgbe: add support for rx-adaptation
Message-ID: <20230131111155.5cb607a6@kernel.org>
In-Reply-To: <c1ddd073-2494-9c8a-0f61-8330d7d6bb0c@amd.com>
References: <20230125072529.2222420-1-Raju.Rangoju@amd.com>
        <20230125072529.2222420-3-Raju.Rangoju@amd.com>
        <20230125230410.79342e6a@kernel.org>
        <f4a2cd5d-7d36-6f4d-6012-7e4e87d44d7c@amd.com>
        <c1ddd073-2494-9c8a-0f61-8330d7d6bb0c@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, 31 Jan 2023 15:26:14 +0530 Raju Rangoju wrote:
> > Sure, I've re-ordered most of the functions correctly to avoid forward 
> > declarations. However, there is circular dependency on couple of them. 
> > Let us know if its fine to have forward declaration for the functions 
> > that have circular-dependency.  
> 
> Gentle reminder!
> 
> Let us know if it is okay to have forward declarations for functions 
> that have circular dependency.

Yes, in case of circular dependencies there's not much we can do.