From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Michael Walle <michael@walle.cc>, Andrew Lunn <andrew@lunn.ch>,
Jiri Pirko <jiri@resnulli.us>,
Heiner Kallweit <hkallweit1@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: PHY firmware update method
Date: Tue, 31 Jan 2023 13:07:53 -0800 [thread overview]
Message-ID: <20230131130753.32e0e5ba@kernel.org> (raw)
In-Reply-To: <7106dccd-4f3d-17a1-0897-604a1025a937@intel.com>
On Tue, 31 Jan 2023 11:56:26 -0800 Jacob Keller wrote:
> On 1/31/2023 10:41 AM, Jakub Kicinski wrote:
> > FWIW we had a concept of "FW load policy" in devlink but IDK if it
> > addresses the concern sufficiently. For mlxsw IIRC the load policy
> > "from disk" means "flash the device if loaded FW is older".
>
> My initial interpretation of this parameter was that "LOAD_DISK" implied
> the device could choose to load the firmware from disk but didn't
> necessarily overwrite what was stored in the flash permanently.
>
> Your interpretation also makes sense on a second review, but I'm not
> sure what "driver" would mean in this context? I guess "whichever driver
> prefers?"
Ah, you're right, I dismembered. Looking at the code 'driver' means
flash to the latest supported by the driver. 'flash' means use what's
there.
For the NFP IIRC 'driver' meant load whichever is newer (but don't
write to flash if disk was newer, just load to sram).
> The parameter does seem like a suitable place to allow admin to specify
> the policy.
next prev parent reply other threads:[~2023-01-31 21:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:27 PHY firmware update method Michael Walle
2022-09-28 12:28 ` Andrew Lunn
2022-09-29 7:04 ` Jiri Pirko
2022-09-29 12:28 ` Andrew Lunn
2022-09-29 14:12 ` Jakub Kicinski
2022-09-29 14:53 ` Andrew Lunn
2022-09-30 8:25 ` Jiri Pirko
2022-09-30 12:36 ` Andrew Lunn
2022-09-30 14:45 ` Jakub Kicinski
2022-09-30 16:49 ` Keller, Jacob E
2022-10-03 12:18 ` Russell King (Oracle)
2022-10-03 14:42 ` Jakub Kicinski
2022-10-03 17:53 ` Keller, Jacob E
2022-10-03 18:04 ` Jacob Keller
2023-01-24 17:13 ` Michael Walle
2023-01-24 17:11 ` Michael Walle
2023-01-24 20:42 ` Andrew Lunn
2023-01-31 16:10 ` Michael Walle
2023-01-31 16:29 ` Russell King (Oracle)
2023-01-31 17:48 ` Michael Walle
2023-01-31 18:36 ` Jacob Keller
2023-01-31 18:41 ` Jakub Kicinski
2023-01-31 19:56 ` Jacob Keller
2023-01-31 21:07 ` Jakub Kicinski [this message]
2023-01-24 22:28 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131130753.32e0e5ba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).