From: Jakub Kicinski <kuba@kernel.org>
To: Praveen Kaligineedi <pkaligineedi@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jeroen de Borst <jeroendb@google.com>
Subject: Re: [PATCH net-next 1/1] gve: Fix gve interrupt names
Date: Wed, 1 Feb 2023 21:18:40 -0800 [thread overview]
Message-ID: <20230201211840.4648f8af@kernel.org> (raw)
In-Reply-To: <20230131213714.588281-1-pkaligineedi@google.com>
On Tue, 31 Jan 2023 13:37:14 -0800 Praveen Kaligineedi wrote:
> IRQs are currently requested before the netdevice is registered
> and a proper name is assigned to the device. Changing interrupt
> name to avoid using the format string in the name.
Please provide an example of what the name used to look like and what
it looks like now.
> Fixes: 893ce44df565 ("gve: Add basic driver framework for Compute Engine Virtual NIC")
If it carries a Fixes tag it should go to net, not net-next,
and describe what the user-visible issue is going to be.
I'd suggest to drop the Fixes tag. It doesn't look like a fix,
it never worked.
> @@ -371,8 +370,8 @@ static int gve_alloc_notify_blocks(struct gve_priv *priv)
> active_cpus = min_t(int, priv->num_ntfy_blks / 2, num_online_cpus());
>
> /* Setup Management Vector - the last vector */
> - snprintf(priv->mgmt_msix_name, sizeof(priv->mgmt_msix_name), "%s-mgmnt",
> - name);
> + snprintf(priv->mgmt_msix_name, sizeof(priv->mgmt_msix_name), "gve%d-mgmnt",
> + PCI_SLOT(priv->pdev->devfn));
Why slot?
Please use the more common "$whatever@pci:%s", pci_name() format.
prev parent reply other threads:[~2023-02-02 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 21:37 [PATCH net-next 1/1] gve: Fix gve interrupt names Praveen Kaligineedi
2023-02-01 9:11 ` Jiri Pirko
2023-02-02 5:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201211840.4648f8af@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jeroendb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pkaligineedi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).