From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <jasowang@redhat.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <netdev@vger.kernel.org>
Cc: <edumazet@google.com>, <pabeni@redhat.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <hawk@kernel.org>,
<virtualization@lists.linux-foundation.org>,
<bpf@vger.kernel.org>, "Parav Pandit" <parav@nvidia.com>
Subject: [PATCH 2/2] virtio-net: Maintain reverse cleanup order
Date: Thu, 2 Feb 2023 07:00:38 +0200 [thread overview]
Message-ID: <20230202050038.3187-3-parav@nvidia.com> (raw)
In-Reply-To: <20230202050038.3187-1-parav@nvidia.com>
To easily audit the code, better to keep the device stop()
sequence to be mirror of the device open() sequence.
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
drivers/net/virtio_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index b7d0b54c3bb0..1f8168e0f64d 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2279,9 +2279,9 @@ static int virtnet_close(struct net_device *dev)
cancel_delayed_work_sync(&vi->refill);
for (i = 0; i < vi->max_queue_pairs; i++) {
+ virtnet_napi_tx_disable(&vi->sq[i].napi);
napi_disable(&vi->rq[i].napi);
xdp_rxq_info_unreg(&vi->rq[i].xdp_rxq);
- virtnet_napi_tx_disable(&vi->sq[i].napi);
}
return 0;
--
2.26.2
next prev parent reply other threads:[~2023-02-02 5:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 5:00 [PATCH 0/2] virtio-net: close() to follow mirror of open() Parav Pandit
2023-02-02 5:00 ` [PATCH 1/2] virtio-net: Keep stop() to follow mirror sequence " Parav Pandit
2023-02-02 12:23 ` Jiri Pirko
2023-02-02 5:00 ` Parav Pandit [this message]
2023-02-02 12:26 ` [PATCH 2/2] virtio-net: Maintain reverse cleanup order Jiri Pirko
2023-02-02 15:10 ` Parav Pandit
2023-02-02 15:46 ` Jiri Pirko
2023-02-02 16:33 ` Parav Pandit
2023-02-02 10:56 ` [PATCH 0/2] virtio-net: close() to follow mirror of open() Michael S. Tsirkin
2023-02-02 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202050038.3187-3-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).