From: Jakub Kicinski <kuba@kernel.org>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
decui@microsoft.com, kys@microsoft.com, paulros@microsoft.com,
olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net,v2] net: mana: Fix accessing freed irq affinity_hint
Date: Thu, 2 Feb 2023 11:38:28 -0800 [thread overview]
Message-ID: <20230202113828.7f2a800c@kernel.org> (raw)
In-Reply-To: <1675288013-2481-1-git-send-email-haiyangz@microsoft.com>
On Wed, 1 Feb 2023 13:46:53 -0800 Haiyang Zhang wrote:
> + irq_set_affinity_and_hint(irq, cpumask_of(cpumask_local_spread
> + (i, gc->numa_node)));
The line break here looks ugly.
Please use a local variable for the mask or the cpu.
next prev parent reply other threads:[~2023-02-02 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 21:46 [PATCH net,v2] net: mana: Fix accessing freed irq affinity_hint Haiyang Zhang
2023-02-01 22:09 ` Michael Kelley (LINUX)
2023-02-02 8:25 ` Leon Romanovsky
2023-02-02 19:38 ` Jakub Kicinski [this message]
2023-02-02 19:54 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202113828.7f2a800c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=paulros@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).