Re: [PATCH net v5 0/2] mlx5: ptp fifo bugfixes

Saeed Mahameed
2023-02-02T18:53:22Z

On 02 Feb 09:13, Vadim Fedorenko wrote:
>Simple FIFO implementation for PTP queue has several bugs which lead to
>use-after-free and skb leaks. This series fixes the issues and adds new
>checks for this FIFO implementation to uncover the same problems in
>future.
>

Thanks Vadim, Applied to net-mlx5.

>v4 -> v5:
> Change check to WARN_ON_ONCE() in mlx5e_skb_fifo_pop()
> Change the check of OOO cqe as Jakub provided corner case
> Move OOO logic into separate function and add counter
>v3 -> v4:
> Change pr_err to mlx5_core_err_rl per suggest
> Removed WARN_ONCE on fifo push because has_room() should catch the
> issue
>v2 -> v3:
> Rearrange patches order and rephrase commit messages
> Remove counters as Gal confirmed FW bug, use KERN_ERR message instead
> Provide proper budget to napi_consume_skb as Jakub suggested
>v1 -> v2:
> Update Fixes tag to proper commit.
> Change debug line to avoid double print of function name
>
>Vadim Fedorenko (2):
> mlx5: fix skb leak while fifo resync and push
> mlx5: fix possible ptp queue fifo use-after-free
>
> .../net/ethernet/mellanox/mlx5/core/en/ptp.c | 25 ++++++++++++++++---
> .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 4 ++-
> .../ethernet/mellanox/mlx5/core/en_stats.c | 1 +
> .../ethernet/mellanox/mlx5/core/en_stats.h | 1 +
> 4 files changed, 27 insertions(+), 4 deletions(-)
>
>--
>2.30.2
>