From: Janne Grunau <j@jannau.net>
To: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Mailing List" <devicetree-spec@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"van Spriel" <arend@broadcom.com>,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Janne Grunau <j@jannau.net>
Subject: [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema
Date: Fri, 03 Feb 2023 14:56:25 +0100 [thread overview]
Message-ID: <20230203-dt-bindings-network-class-v1-0-452e0375200d@jannau.net> (raw)
The Devicetree Specification, Release v0.3 specifies in section 4.3.1
a "Network Class Binding". This covers MAC address and maximal frame
size properties. "local-mac-address" and "mac-address" with a fixed
address-size of 48 bits is already in the ethernet-controller.yaml
schema so move those over.
I think the only commonly used values for address-size are 48 and 64
bits (EUI-48 and EUI-64). Unfortunately I was not able to restrict the
mac-address size based on the address-size. This seems to be an side
effect of the array definition and I was not able to restrict "minItems"
or "maxItems" based on the address-size value in an "if"-"then"-"else"
block.
An easy way out would be to restrict address-size to 48-bits for now.
I've ignored "max-frame-size" since the description in
ethernet-controller.yaml claims there is a contradiction in the
Devicetree specification. I suppose it is describing the property
"max-frame-size" with "Specifies maximum packet length ...".
My understanding from the dt-schema README is that network-class.yaml
should live in the dt-schema repository since it describes properties
from the Devicetree specification. How is the synchronization handled in
this case? The motivation for this series is to fix dtbs_check failures
for Apple silicon devices both in the tree and upcoming ones.
Signed-off-by: Janne Grunau <j@jannau.net>
---
Janne Grunau (3):
dt-bindings: net: Add network-class schema for mac-address properties
dt-bindings: wireless: bcm4329-fmac: Use network-class.yaml schema
dt-bindings: wireless: silabs,wfx: Use network-class.yaml
.../bindings/net/ethernet-controller.yaml | 18 +---------
.../devicetree/bindings/net/network-class.yaml | 40 ++++++++++++++++++++++
.../bindings/net/wireless/brcm,bcm4329-fmac.yaml | 5 ++-
.../bindings/net/wireless/silabs,wfx.yaml | 5 +--
4 files changed, 46 insertions(+), 22 deletions(-)
---
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
change-id: 20230203-dt-bindings-network-class-8367edd679d2
Best regards,
--
Janne Grunau <j@jannau.net>
next reply other threads:[~2023-02-03 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:56 Janne Grunau [this message]
2023-02-03 13:56 ` [PATCH RFC 1/3] dt-bindings: net: Add network-class schema for mac-address properties Janne Grunau
2023-02-03 14:25 ` Rob Herring
2023-02-03 21:08 ` Krzysztof Kozlowski
2023-02-03 13:56 ` [PATCH RFC 2/3] dt-bindings: wireless: bcm4329-fmac: Use network-class.yaml schema Janne Grunau
2023-02-03 13:56 ` [PATCH RFC 3/3] dt-bindings: wireless: silabs,wfx: Use network-class.yaml Janne Grunau
2023-02-03 14:41 ` [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema Rob Herring
2023-02-06 16:31 ` Janne Grunau
2023-02-07 1:34 ` Andrew Lunn
2023-02-07 7:10 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203-dt-bindings-network-class-v1-0-452e0375200d@jannau.net \
--to=j@jannau.net \
--cc=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jerome.pouiller@silabs.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).