From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61284C61DA4 for ; Fri, 3 Feb 2023 09:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232523AbjBCJIG (ORCPT ); Fri, 3 Feb 2023 04:08:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232142AbjBCJIF (ORCPT ); Fri, 3 Feb 2023 04:08:05 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0AF31BDC for ; Fri, 3 Feb 2023 01:07:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675415239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lcpnbERMPxMIk4rSMsJPyxbYfxtUlhTSWcolKETapCs=; b=QonDO71I+IC38McjLdJn0LyvUsulYFwgWVF/c6081rfwhCkoWFPWNbuXyha1o7RmFimrMz XZAwCL29Igx8Y9HuDt9irMfiHyiw0VVhpzdzWQcLO9q2Yr32BvfGTDqtxQsznoG9da/HjU A/7/v+h7UVMj/i+n8+XNscxJK9PcB0c= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-322-c1FLxxPdOGCEKZlQcKgfmg-1; Fri, 03 Feb 2023 04:07:17 -0500 X-MC-Unique: c1FLxxPdOGCEKZlQcKgfmg-1 Received: by mail-ej1-f69.google.com with SMTP id ti11-20020a170907c20b00b00886244203fcso3453744ejc.2 for ; Fri, 03 Feb 2023 01:07:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lcpnbERMPxMIk4rSMsJPyxbYfxtUlhTSWcolKETapCs=; b=y4tzQ7fPfg1OdS3LHZenOP41sEct38rfDeXQ0tYehbmOmNF9/xbXDyhclsXdeUNVVD j3LZled6MhJ36/8xXiE9gJ510JXmj4OO3T+NA1jSPv99sxpLU5vM11ieUu0B1U8N+CTU BS6/LsS7pj+CUAjNBmLSn3tMrZOJX8Y82oVQP64XAow0N6GIiMOB07u5TKig8zsBsfKx AcgyK234VoLhIsAenIWbHQYwscLFXh1KRr+0/3Lu6ooB0pO8/5F4En7GPrpbCdd7oJbP hvuy3NNZHHqNJNQtru4zCFsnny5iF0jKdC3DY411FdWWmoZUYEC4QQaeR0SbvJR8cKDn S3TQ== X-Gm-Message-State: AO0yUKX+dHEj+m2hTKuIwkRc5YCnfvf2RBNeAPomYLb0RaiuAYarO603 fExTh5psNFTDDLRLkI4GsRE3kLHyY4188uD0h25vD2Y0+DNCnqkz4ftiHcixVa/WpeZr5YEg+Rr DCO78P6mcIaHiKUf6 X-Received: by 2002:a50:d088:0:b0:4a2:3d3d:a3d9 with SMTP id v8-20020a50d088000000b004a23d3da3d9mr9092213edd.2.1675415236393; Fri, 03 Feb 2023 01:07:16 -0800 (PST) X-Google-Smtp-Source: AK7set/JGZiQysBGfBbJ3E1QUQsRtGGsv7wF/0eyNNTeOrg2il3rlRP8/URTnNDtbpX9I5F+ED6I/Q== X-Received: by 2002:a50:d088:0:b0:4a2:3d3d:a3d9 with SMTP id v8-20020a50d088000000b004a23d3da3d9mr9092201edd.2.1675415236167; Fri, 03 Feb 2023 01:07:16 -0800 (PST) Received: from redhat.com ([2.52.156.122]) by smtp.gmail.com with ESMTPSA id b9-20020a0564021f0900b004a21304f5a0sm799006edb.72.2023.02.03.01.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 01:07:15 -0800 (PST) Date: Fri, 3 Feb 2023 04:07:10 -0500 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jason Wang , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Sebastian Andrzej Siewior , Menglong Dong , Kuniyuki Iwashima , Petr Machata , virtualization@lists.linux-foundation.org, bpf@vger.kernel.org Subject: Re: [PATCH 07/33] virtio_ring: add api virtio_dma_map() for advance dma Message-ID: <20230203040621-mutt-send-email-mst@kernel.org> References: <20230202110058.130695-1-xuanzhuo@linux.alibaba.com> <20230202110058.130695-8-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202110058.130695-8-xuanzhuo@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 02, 2023 at 07:00:32PM +0800, Xuan Zhuo wrote: > Added virtio_dma_map() to map DMA addresses for virtual memory in > advance. The purpose of adding this function is to check > vring_use_dma_api() for virtio dma operation and get vdev->dev.parent as > the parameter of dma_map_page(). No this looks like the implementation not the purpose. I am guessing the purpose is to keep memory mapped across multiple add/get buf operations right? > Added virtio_dma_unmap() for unmap DMA address. > > Signed-off-by: Xuan Zhuo > --- > drivers/virtio/virtio_ring.c | 80 ++++++++++++++++++++++++++++++++++++ > include/linux/virtio.h | 9 ++++ > 2 files changed, 89 insertions(+) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 7dfce7001f9f..67eda7bc23ea 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -3022,4 +3022,84 @@ const struct vring *virtqueue_get_vring(struct virtqueue *vq) > } > EXPORT_SYMBOL_GPL(virtqueue_get_vring); > > +/** > + * virtio_dma_map_page - get the DMA addr of the memory for virtio device > + * @dev: virtio device > + * @page: the page of the memory to DMA > + * @offset: the offset of the memory inside page > + * @length: memory length > + * @dir: DMA direction > + * > + * Returns the DMA addr. DMA_MAPPING_ERROR means error. > + */ > +dma_addr_t virtio_dma_map_page(struct device *dev, struct page *page, size_t offset, > + unsigned int length, enum dma_data_direction dir) > +{ > + struct virtio_device *vdev = dev_to_virtio(dev); > + > + if (!vring_use_dma_api(vdev)) > + return page_to_phys(page) + offset; > + > + return dma_map_page(vdev->dev.parent, page, offset, length, dir); > +} > + > +/** > + * virtio_dma_map - get the DMA addr of the memory for virtio device > + * @dev: virtio device > + * @addr: the addr to DMA > + * @length: memory length > + * @dir: DMA direction > + * > + * Returns the DMA addr. > + */ > +dma_addr_t virtio_dma_map(struct device *dev, void *addr, unsigned int length, > + enum dma_data_direction dir) > +{ > + struct page *page; > + size_t offset; > + > + page = virt_to_page(addr); > + offset = offset_in_page(addr); > + > + return virtio_dma_map_page(dev, page, offset, length, dir); > +} > +EXPORT_SYMBOL_GPL(virtio_dma_map); > + > +/** > + * virtio_dma_mapping_error - check dma address > + * @dev: virtio device > + * @addr: DMA address > + * > + * Returns 0 means dma valid. Other means invalid dma address. > + */ > +int virtio_dma_mapping_error(struct device *dev, dma_addr_t addr) > +{ > + struct virtio_device *vdev = dev_to_virtio(dev); > + > + if (!vring_use_dma_api(vdev)) > + return 0; > + > + return dma_mapping_error(vdev->dev.parent, addr); > +} > +EXPORT_SYMBOL_GPL(virtio_dma_mapping_error); > + > +/** > + * virtio_dma_unmap - unmap DMA addr > + * @dev: virtio device > + * @dma: DMA address > + * @length: memory length > + * @dir: DMA direction > + */ > +void virtio_dma_unmap(struct device *dev, dma_addr_t dma, unsigned int length, > + enum dma_data_direction dir) > +{ > + struct virtio_device *vdev = dev_to_virtio(dev); > + > + if (!vring_use_dma_api(vdev)) > + return; > + > + dma_unmap_page(vdev->dev.parent, dma, length, dir); > +} > +EXPORT_SYMBOL_GPL(virtio_dma_unmap); > + > MODULE_LICENSE("GPL"); > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > index 3ca2edb1aef3..ce89126becc5 100644 > --- a/include/linux/virtio.h > +++ b/include/linux/virtio.h > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > > /** > * struct virtqueue - a queue to register buffers for sending or receiving. > @@ -218,4 +219,12 @@ void unregister_virtio_driver(struct virtio_driver *drv); > #define module_virtio_driver(__virtio_driver) \ > module_driver(__virtio_driver, register_virtio_driver, \ > unregister_virtio_driver) > + > +dma_addr_t virtio_dma_map_page(struct device *dev, struct page *page, size_t offset, > + unsigned int length, enum dma_data_direction dir); > +dma_addr_t virtio_dma_map(struct device *dev, void *addr, unsigned int length, > + enum dma_data_direction dir); > +int virtio_dma_mapping_error(struct device *dev, dma_addr_t addr); > +void virtio_dma_unmap(struct device *dev, dma_addr_t dma, unsigned int length, > + enum dma_data_direction dir); > #endif /* _LINUX_VIRTIO_H */ > -- > 2.32.0.3.g01195cf9f