Netdev List
 help / color / mirror / Atom feed
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next] net: lan966x: Add support for TC flower filter statistics
Date: Mon, 6 Feb 2023 11:32:52 +0100	[thread overview]
Message-ID: <20230206103252.xxqd5zvhvfdium4a@soft-dev3-1> (raw)
In-Reply-To: <Y+DPbbqPyskMBsSJ@corigine.com>

The 02/06/2023 10:59, Simon Horman wrote:
> 
> > > Also, not strictly related, but could you consider, as a favour to
> > > reviewers, fixing the driver so that the following doesn't fail:
> > >
> > > $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > >   DESCEND objtool
> > >   CALL    scripts/checksyscalls.sh
> > >   CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
> > > drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
> > >    18 | #include <vcap_api.h>
> > >       |          ^~~~~~~~~~~~
> > > compilation terminated.
> >
> > I will try to have a look at this.
> 
> Thanks, much appreciated.

Sorry for coming back to this, but it seems that I can't reproduce the
issue:

$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o

I have tried different configurations without any luck. Any suggestion
on how to reproduce the issue?

-- 
/Horatiu

  reply	other threads:[~2023-02-06 10:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 13:53 [PATCH net-next] net: lan966x: Add support for TC flower filter statistics Horatiu Vultur
2023-02-04 17:12 ` Simon Horman
2023-02-06  9:52   ` Horatiu Vultur
2023-02-06  9:59     ` Simon Horman
2023-02-06 10:32       ` Horatiu Vultur [this message]
2023-02-06 10:42         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230206103252.xxqd5zvhvfdium4a@soft-dev3-1 \
    --to=horatiu.vultur@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox